Revert "(Partially) revert #6148"

[csweichel]

Reverts #6170

The original partial revert is without consequence as gRPC has a minimum of 10 seconds here.
The actual fix for the underlying issue is #6166

NONE

[csweichel]

/hold until #6166 is merged

[codecov]

Codecov Report

Merging #6181 (a0a3efc) into main (7dfe6e2) will increase coverage by 15.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #6181       +/-   ##
===========================================
+ Coverage   19.04%   34.07%   +15.02%     
===========================================
  Files           2      128      +126     
  Lines         168    22172    +22004     
===========================================
+ Hits           32     7554     +7522     
- Misses        134    13934    +13800     
- Partials        2      684      +682     

Flag	Coverage Δ
components-blobserve-app	31.34% <ø> (?)
components-blobserve-lib	31.34% <ø> (?)
components-common-go-lib	36.89% <ø> (?)
components-content-service-api-go-lib	∅ <ø> (?)
components-content-service-app	14.48% <ø> (?)
components-content-service-lib	14.48% <ø> (?)
components-ee-agent-smith-app	34.10% <ø> (?)
components-ee-agent-smith-lib	34.10% <ø> (?)
components-ee-kedge-app	45.48% <ø> (?)
components-ee-ws-scheduler-app	63.89% <ø> (?)
components-ee-ws-scheduler-lib	63.89% <ø> (?)
components-image-builder-api-go-lib	∅ <ø> (?)
components-image-builder-app	34.44% <ø> (?)
components-image-builder-bob-app	∅ <ø> (?)
components-image-builder-mk3-app	34.76% <ø> (?)
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-openvsx-proxy-app	46.22% <ø> (?)
components-registry-facade-app	11.85% <ø> (?)
components-registry-facade-lib	11.85% <ø> (?)
components-service-waiter-app	∅ <ø> (?)
components-supervisor-app	38.69% <ø> (?)
components-workspacekit-app	7.09% <ø> (?)
components-ws-daemon-api-go-lib	∅ <ø> (?)
components-ws-daemon-app	22.11% <ø> (?)
components-ws-daemon-lib	22.11% <ø> (?)
components-ws-daemon-nsinsider-app	∅ <ø> (?)
components-ws-manager-api-go-lib	∅ <ø> (?)
components-ws-manager-app	39.37% <ø> (?)
components-ws-proxy-app	69.53% <ø> (?)
components-ws-proxy-lib	69.53% <ø> (?)
dev-loadgen-app	∅ <ø> (?)
dev-poolkeeper-app	∅ <ø> (?)
installer-app	6.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
...onents/content-service/pkg/initializer/download.go	76.31% <0.00%> (ø)
...nts/content-service/pkg/initializer/initializer.go	5.14% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/egress.go	0.00% <0.00%> (ø)
components/workspacekit/cmd/rings.go	6.97% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go	50.73% <0.00%> (ø)
components/ws-proxy/pkg/proxy/pass.go	74.40% <0.00%> (ø)
components/supervisor/pkg/terminal/ring-buffer.go	45.65% <0.00%> (ø)
...onents/content-service/pkg/initializer/prebuild.go	0.00% <0.00%> (ø)
... and 120 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dfe6e2...a0a3efc. Read the comment docs.

[geropl]

Please, before we do this right away: have a look at https://console.cloud.google.com/errors/CISRmNnx2fnk5wE?time=P7D&project=gitpod-staging

• why does it occur when [common-go] Adjust log level and ping keepalive interval #6148 got deployed to staging
• why did it vanish after (Partially) revert #6148 #6170 got deployed

Not saying #6170 is particularly good solution (was meant as a temporary measure after all), and sorry if I did not communicate well here. But let's find out what went wrong and how to mitigate! 🏀

[geropl]

Ah, just found #6166 Nice that you found out, why not have both in one PR for context?

[csweichel]

Ah, just found #6166 Nice that you found out, why not have both in one PR for context?

#6166 came before the partial revert and this revert of the partial revert :)

[csweichel]

/hold cancel

[aledbf]

/werft run

👍 started the job as gitpod-build-revert-6170-gpl-revert-6148.1

[aledbf]

/lgtm
/approve no-issue

[roboquat]

LGTM label has been added.

Git tree hash: ad3eeb776075a9aa40a56bbb366b5bce6928ea0f

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #6170

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/common-go/OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment