[projects] Fix Project card bottom row layout #6187

jankeromnes · 2021-10-13T08:50:04Z

Description

Fixes the bottom row flex layout of Project cards.

Related Issue(s)

How to test

Release Notes

[projects] Fix Project card bottom row layout

Documentation

/uncc

jankeromnes · 2021-10-13T10:18:52Z

/werft run

👍 started the job as gitpod-build-jx-fix-project-card.1

jankeromnes · 2021-10-13T10:33:26Z

Ready for review! 😁 This is what it now looks like:

"Normal" screen (e.g. 15" retina)	Larger screen (e.g. external monitor)

@gtsiolis could you please take a look when you have some time? 🙏

gtsiolis · 2021-10-13T13:20:31Z

Looking at this now! 👀

gtsiolis

Flawless, as usual, @jankeromnes! 🌟

Left one minor suggestion below.

Approving to unblock merging but holding in case we could squeeze also that small spacing issue. 🍊

/hold

gtsiolis · 2021-10-13T16:36:39Z

components/dashboard/src/projects/Projects.tsx

@@ -151,16 +151,14 @@ export default function () {
                        </div>
                        <div className="h-10 px-4 border rounded-b-xl dark:border-gray-800 bg-gray-100 border-gray-100 dark:bg-gray-800">
                            {lastPrebuilds.get(p.id)
-                                ? (<div className="flex flex-row h-full text-sm justify-between">
-                                    <Link to={`/${teamOrUserSlug}/${p.name}/${lastPrebuilds.get(p.id)?.info?.id}`} className="flex my-auto items-center group space-x-2">
+                                ? (<div className="flex flex-row h-full text-sm space-x-2">


suggestion: What do you think of adding some more space between the latest prebuild and the link to view all prebuilds? See also principles of grouping. 🤓

Suggested change

? (<div className="flex flex-row h-full text-sm space-x-2">

? (<div className="flex flex-row h-full text-sm space-x-4">

BEFORE AFTER

roboquat · 2021-10-13T16:38:39Z

LGTM label has been added.

Git tree hash: 791410649cbe5784d2372b8f832d06b39f8bca7a

roboquat · 2021-10-13T16:38:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis

Associated issue: #5978

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [gtsiolis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jankeromnes · 2021-10-14T06:10:00Z

Flawless, as usual, @jankeromnes! 🌟

So much praise 😊 thank you for the flawless review, as usual!

suggestion: What do you think of adding some more space between the latest prebuild and the link to view all prebuilds? See also principles of grouping. 🤓

I like it! Thank you for the small touch that makes the entire thing much nicer. ✨

roboquat · 2021-10-14T06:11:23Z

New changes are detected. LGTM label has been removed.

Co-authored-by: George Tsiolis <tsiolis.g@gmail.com>

jankeromnes · 2021-10-14T06:39:45Z

(The first build did not actually fail, and the result looks as expected.)

Carrying over the lgtm label, since the only changes were:

a rebase
applying the suggested CSS class change

And removing the block as well 🚀

jankeromnes · 2021-10-14T06:40:15Z

/werft run

👍 started the job as gitpod-build-jx-fix-project-card.4

jankeromnes · 2021-10-14T06:49:57Z

Come on bitnami, let's try this again!

/werft run

👍 started the job as gitpod-build-jx-fix-project-card.5

roboquat added release-note do-not-merge/work-in-progress team: webapp Issue belongs to the WebApp team size/S labels Oct 13, 2021

jankeromnes force-pushed the jx/fix-project-card branch from 6567972 to 9ba55bf Compare October 13, 2021 09:25

jankeromnes marked this pull request as ready for review October 13, 2021 10:29

roboquat removed the do-not-merge/work-in-progress label Oct 13, 2021

jankeromnes requested a review from gtsiolis October 13, 2021 10:33

jankeromnes added the approved label Oct 13, 2021

gtsiolis approved these changes Oct 13, 2021

View reviewed changes

roboquat added the do-not-merge/hold label Oct 13, 2021

roboquat assigned gtsiolis Oct 13, 2021

roboquat added the lgtm label Oct 13, 2021

jankeromnes force-pushed the jx/fix-project-card branch from 9ba55bf to 987957e Compare October 14, 2021 06:11

roboquat removed the lgtm label Oct 14, 2021

[projects] Fix Project card bottom layout

7064e05

Co-authored-by: George Tsiolis <tsiolis.g@gmail.com>

jankeromnes force-pushed the jx/fix-project-card branch from 987957e to 7064e05 Compare October 14, 2021 06:11

jankeromnes added lgtm and removed do-not-merge/hold labels Oct 14, 2021

roboquat merged commit 0c4c212 into main Oct 14, 2021

roboquat deleted the jx/fix-project-card branch October 14, 2021 06:52

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[projects] Fix Project card bottom row layout #6187

[projects] Fix Project card bottom row layout #6187

jankeromnes commented Oct 13, 2021

jankeromnes commented Oct 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

gtsiolis Oct 13, 2021 •

edited

Loading

roboquat commented Oct 13, 2021

roboquat commented Oct 13, 2021

jankeromnes commented Oct 14, 2021 •

edited

Loading

roboquat commented Oct 14, 2021

jankeromnes commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading

	? (<div className="flex flex-row h-full text-sm space-x-2">
	? (<div className="flex flex-row h-full text-sm space-x-4">

[projects] Fix Project card bottom row layout #6187

[projects] Fix Project card bottom row layout #6187

Conversation

jankeromnes commented Oct 13, 2021

Description

Related Issue(s)

How to test

Release Notes

Documentation

jankeromnes commented Oct 13, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Oct 13, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Oct 13, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis Oct 13, 2021 • edited Loading

Choose a reason for hiding this comment

roboquat commented Oct 13, 2021

roboquat commented Oct 13, 2021

jankeromnes commented Oct 14, 2021 • edited Loading

roboquat commented Oct 14, 2021

jankeromnes commented Oct 14, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Oct 14, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Oct 14, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Oct 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis Oct 13, 2021 •

edited

Loading

jankeromnes commented Oct 14, 2021 •

edited

Loading

jankeromnes commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading