Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing go dependency #6189

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add missing go dependency #6189

merged 1 commit into from
Oct 13, 2021

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Oct 13, 2021

Description

Add missing go dependency since #6163

"golang.org/x/xerrors"

Related Issue(s)

How to test

Release Notes

NONE

Documentation

@roboquat roboquat added the team: workspace Issue belongs to the Workspace team label Oct 13, 2021
@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 13, 2021

/assign @aledbf

@csweichel
Copy link
Contributor

csweichel commented Oct 13, 2021

/werft run no-preview

👍 started the job as gitpod-build-pd-add-missing-go-dep2-fork.0
/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca743864aab716b7ca66105ee2ab058fdeb5d7e0

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6163

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 13, 2021

build failed, but why?

@aledbf
Copy link
Member

aledbf commented Oct 13, 2021

/werft run no-preview

👍 started the job as gitpod-build-pd-add-missing-go-dep2-fork.1

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #6189 (93170cc) into main (9d4bfb5) will increase coverage by 20.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6189       +/-   ##
===========================================
+ Coverage   19.04%   39.88%   +20.83%     
===========================================
  Files           2       73       +71     
  Lines         168    14975    +14807     
===========================================
+ Hits           32     5973     +5941     
- Misses        134     8526     +8392     
- Partials        2      476      +474     
Flag Coverage Δ
components-ee-ws-scheduler-app 63.89% <ø> (?)
components-ee-ws-scheduler-lib 64.06% <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-mk3-app 35.17% <ø> (?)
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 37.93% <ø> (?)
components-ws-daemon-app 22.11% <ø> (?)
components-ws-daemon-lib 22.11% <ø> (?)
components-ws-manager-app 39.47% <ø> (?)
components-ws-proxy-app 69.68% <ø> (?)
components-ws-proxy-lib 69.68% <ø> (?)
installer-app 6.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 24.90% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.11% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
components/ee/ws-scheduler/pkg/scaler/metrics.go 22.85% <0.00%> (ø)
components/ee/ws-scheduler/pkg/scaler/time.go 66.66% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go 73.46% <0.00%> (ø)
...ponents/ee/ws-scheduler/pkg/scheduler/scheduler.go 57.73% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4bfb5...93170cc. Read the comment docs.

@roboquat roboquat merged commit 4bbdd2c into gitpod-io:main Oct 13, 2021
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 31, 2021
@iQQBot iQQBot deleted the pd/add-missing-go-dep2 branch November 4, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved community-contribution deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants