Fixes to install workspace components to GKE with InCluster dependencies #6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer-gke
branch
from
d0b8661
to
e16e081
Compare
Codecov Report
@@ Coverage Diff @@
## main #6323 +/- ##
==========================================
- Coverage 19.04% 17.49% -1.55%
==========================================
Files 2 23 +21
Lines 168 3006 +2838
==========================================
+ Hits 32 526 +494
- Misses 134 2417 +2283
- Partials 2 63 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mrsimonemms
force-pushed
the
sje/installer-gke
branch
4 times, most recently
from
cd8d53f
to
9d9a1d3
Compare
mrsimonemms
changed the title
mrsimonemms
changed the title
|
Can you give me another cluster to test? |
princerachit
suggested changes
Oct 25, 2021
There was a problem hiding this comment.
I think some recent commit broke the code:
gitpod /workspace/gitpod/installer $ go run . render --config example-config.yaml | kubectl apply -f -# github.com/gitpod-io/gitpod/installer/pkg/components/content-service
pkg/components/content-service/objects.go:14:65: cannot use nil as type bool in argument to common.GenerateService
# github.com/gitpod-io/gitpod/installer/pkg/components/dashboard
pkg/components/dashboard/objects.go:13:65: cannot use nil as type bool in argument to common.GenerateService
# github.com/gitpod-io/gitpod/installer/pkg/components/server
pkg/components/server/objects.go:16:65: cannot use nil as type bool in argument to common.GenerateService
# github.com/gitpod-io/gitpod/installer/pkg/components/image-builder-mk3
pkg/components/image-builder-mk3/objects.go:16:65: cannot use nil as type bool in argument to common.GenerateService
Yeah, my bad. I'll get this fixed before out 9:30BST call
princerachit
suggested changes
Oct 25, 2021
mrsimonemms
force-pushed
the
sje/installer-gke
branch
5 times, most recently
from
2003367
to
a4cb89f
Compare
added 3 commits
October 26, 2021 08:56
Set the versions to `main.1640`, which is currently what is deployed to production
mrsimonemms
force-pushed
the
sje/installer-gke
branch
from
a4cb89f
to
f12552c
Compare
csweichel
reviewed
Oct 26, 2021
mrsimonemms
force-pushed
the
sje/installer-gke
branch
2 times, most recently
from
9a66833
to
46ee3c1
Compare
csweichel
reviewed
Oct 27, 2021
csweichel
reviewed
Oct 27, 2021
added 5 commits
October 27, 2021 11:40
The cluster configuration is designed for components that are always installed to the cluster. These will mostly be security related rather than functional. This also introduces the concept of common objects that are installed regardless of the installation type.
…P was always set to None
This now installs the workspace components to a cluster using an InCluster database and registry
mrsimonemms
force-pushed
the
sje/installer-gke
branch
from
46ee3c1
to
7f6b292
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: def100f1c468b05432cb6d58c2930565587c0046
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6276 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the bugfixes required to get the application deployed to a GKE cluster. As this was getting large, this has been split into Workspace and Meta component
This has made a change to the
configfile as well:workspace.runtime.containerdSocket(with default value). This is necessary as containerd can be in different locations (eg, in Azure)Probein theWorkspaceTemplates. This won't be defined in most instances, but is necessary for completionAlso, I've changed how the DB init scripts work. I've removed the scripts
00-testdb-user.sqland01-create-user.sqlreplaced with the Helm configuration for creating a username/database. I don't think this will actually present a functional change, but happy to have a conversation about this - this appears only to be run with InCluster databases.Related Issue(s)
Fixes #6276
How to test
gcloud container clusters get-credentials sje-europe-west2-primary-gke --region europe-west2 --project sje-self-hosted-playground(I'm also using this cluster)go run . render --config example-config.yaml | kubectl apply -f -watch kubectl get podsand watch the pods come to life - this takes ~3 minsRelease Notes
Documentation