[supervisor] Replace dropbear with openssh

[aledbf]

Description

This PR switches to OpenSSH instead of dropbear, and starts sshd only when a connection to the SSH service is made.
This should drastically improve workspace startup time, and subsequently image build and prebuild stability.

Related Issue(s)

Fixes #4848

How to test

1. start a workspace
2. try local companion app
3. try to ssh from within the workspace into the workspace
4. check after closing the local companion app there are no sshd: gitpod [priv] process running in the workspace after a couple of seconds

Release Notes

Switch from dropbear to OpenSSH

Documentation

[codecov]

Codecov Report

Merging #6348 (1f467a3) into main (1d7c6ca) will increase coverage by 19.10%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #6348       +/-   ##
===========================================
+ Coverage   19.04%   38.14%   +19.10%     
===========================================
  Files           2       18       +16     
  Lines         168     4375     +4207     
===========================================
+ Hits           32     1669     +1637     
- Misses        134     2576     +2442     
- Partials        2      130      +128     

Flag	Coverage Δ
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-supervisor-app	38.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/supervisor/pkg/supervisor/ssh.go	0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/supervisor.go	6.57% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/supervisor/pkg/supervisor/config.go	4.51% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go	32.38% <0.00%> (ø)
components/supervisor/pkg/supervisor/git.go	0.00% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go	73.46% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go	24.90% <0.00%> (ø)
components/supervisor/pkg/terminal/terminal.go	64.19% <0.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7c6ca...1f467a3. Read the comment docs.

[akosyakov]

Why do we do it? Please test that it does not introduce regressions in VS Code Desktop. Especially for things which we had to patch in dropbear.

[csweichel]

/werft run

👍 started the job as gitpod-build-aledbf-ssh2.17

[csweichel]

Why do we do it? Please test that it does not introduce regressions in VS Code Desktop. Especially for things which we had to patch in dropbear.

Good points - I've updated the description of the PR to answer those questions.

W.r.t. to regression, once we find that this approach actually provides the benefits we hope it does, we'll need some support from @gitpod-io/engineering-ide to ensure we're not missing some case.

[iQQBot]

mark

[csweichel]

It does not look like env vars are propagated properly to VS Code Server:

Language support and terminals are broken in VS Code Desktop. The was an internal thread about it: https://gitpod.slack.com/archives/C01V4DL9Q2Z/p1631006119029300

Also #5768 is happening again. We had to patch dropbear to be less picky. It will break some users setup.

@akosyakov both issues should be fixed now

[akosyakov]

/lgtm

everything works, that's awesome guys ❤️

[roboquat]

LGTM label has been added.

Git tree hash: c83b334f9296f82c8633d23453f808b4d116ccab

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue: #4848

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [akosyakov]
• components/supervisor/OWNERS [akosyakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment