[projects] always enable New Workspace button on config page #6389

AlexTugarev · 2021-10-25T14:33:58Z

Playing around with New Workspace button to trigger a prebuild and launch a workspace for that.

Triggering a prebuild, or waiting for the response seems to add ~2 seconds. I'm not sure if we'll see timing issue if the await would be removed, at least I couldn't force a second prebuild on the same sha+config.

Resolves #6303

Always enable the New Workspace button on the Configuration Page.

svenefftinge · 2021-10-26T12:53:19Z

I thought we could just show one button, that would use the https://gitpod.io/#prebuild context URL.
People would end up on the prebuild page (optionally skip it ) and automatically land in a workspace.

I think we should add something like "What's a prebuild?" to this screen. cc @gtsiolis

AlexTugarev · 2021-10-26T13:14:47Z

I thought we could just show one button, that would use the https://gitpod.io/#prebuild context URL.

as the prebuild context url was subject to be phased out for regular usage, it wasn't considered for prebuilds with the additional configuration, as far as I see. given that, the only path to use the config in a following prebuild is to store it first, trigger a new prebuild, and then start a workspace.

jldec · 2021-10-26T14:36:14Z

components/dashboard/src/projects/ConfigureProject.tsx

+  - init: echo 'TODO: build project'
+    command: echo 'TODO: start app'`


I like what you did here (undetected project yaml using valid echo commands) 🙂 👍

@AlexTugarev, unfortunately the yaml doesn't parse : inside a string unless the whole value is quoted.
I recommend using the | and putting the echo command like you have it indented on the next line.

tasks: - init: | echo 'TODO: build project' command: | echo 'TODO: start app'

nice catch! thanks!

jldec · 2021-10-26T14:42:07Z

components/dashboard/src/App.tsx

@@ -239,7 +239,7 @@ function App() {
                <Route path="/admin/workspaces" component={WorkspacesSearch} />

                <Route path={["/", "/login"]} exact>
-                    <Redirect to="/workspaces" />
+                    <Redirect to="/workspaces?blabla" />


Why is this ?blabla here?

oh, that's a leftover. (I had a hard time to convince react router to redirect to /#context_url and this was a test to see where the redirect broke. then just forgot to remove it. )

jldec · 2021-10-26T15:53:41Z

Thanks @AlexTugarev

This does accomplish the main objective of unblocking users who get stuck with invalid yaml 👍

I do have similar feedback as @svenefftinge. I think new users will still be confused by 2 buttons especially when the less familiar "Run Prebuild" button is the green one.

I propose the following small UI changes to address this
I am also open to Sven's suggestion, if you think the work/risk involved to do that is not much more

UI Proposal

swap the order of the 2 buttons.
make "New Workspace" the green one (now on the right)
make "Run Prebuild" not-green.
change the help text in the pane to include a link to the prebuild docs as well i.e.

No Recent Prebuild
Edit the project configuration on the left to get started. Learn more about prebuilds and .gitpod.yml

jldec · 2021-10-27T08:58:04Z

@gtsiolis wdyt - are you 👍 with this?

It seems like the easiest way to reduce confusion about 2 buttons, and also preserve the abililty to do a quick inner-loop edit-run-prebuild.

UI Proposal

swap the order of the 2 buttons.

make "New Workspace" the green one (now on the right)

make "Run Prebuild" not-green.

change the help text in the pane to include a link to the prebuild docs as well i.e.

cc: @svenefftinge

gtsiolis · 2021-10-27T09:03:35Z

/werft run

👍 started the job as gitpod-build-at-new-workspace.4

gtsiolis · 2021-10-27T10:38:27Z

Looking at this now! 👀

AlexTugarev · 2021-10-27T15:22:35Z

/werft run

👍 started the job as gitpod-build-at-new-workspace.6

jldec · 2021-10-28T07:59:07Z

Discussed with @AlexTugarev and @gtsiolis

Decided to resolve #6303 with minimal button changes and not remove the logs output from the project configuration page in this PR.

Will track that work separately in #5785

AlexTugarev · 2021-10-28T12:16:21Z

@jldec, please have a look again. 🙏🏻

jldec · 2021-10-28T12:40:13Z

components/dashboard/src/projects/ConfigureProject.tsx

+  - init: echo 'TODO: build project'
+    command: echo 'TODO: start app'`


@AlexTugarev, unfortunately the yaml doesn't parse : inside a string unless the whole value is quoted.
I recommend using the | and putting the echo command like you have it indented on the next line.

tasks: - init: | echo 'TODO: build project' command: | echo 'TODO: start app'

jldec · 2021-10-28T12:44:42Z

b.t.w
I recommend https://onlineyamltools.com/convert-yaml-to-json for testing yaml,
and https://yaml-multiline.info/ for multiline docs

gptest1 · 2021-10-28T13:41:44Z

@AlexTugarev do you think we could allow the NewWorkspaceButton without waiting for isDetecting? Detection is currently not working for private repos and maybe it might fail for other reasons in future, so allowing the flow to continue to the New Workspace without detection would be better IMO.

Alternatively, the detection could block theflow for a 1 or 2 seconds, but then time-out (or err-out) and allow New Workspace to continue.

roboquat · 2021-10-28T21:42:47Z

LGTM label has been added.

Git tree hash: 410513446588bce9969b63355689c46eb76a0d94

roboquat · 2021-10-28T21:42:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #6303

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [jldec]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jldec · 2021-10-28T21:55:36Z

I resolved the "requested changes" (yaml fix) which triggered an approved review, and then a merge.

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed team: webapp Issue belongs to the WebApp team labels Oct 25, 2021

roboquat requested a review from JanKoehnlein October 25, 2021 14:34

roboquat added the size/S label Oct 25, 2021

AlexTugarev force-pushed the at/new-workspace branch from 7ec441b to da3574c Compare October 26, 2021 12:07

roboquat added size/M and removed size/S labels Oct 26, 2021

AlexTugarev requested review from gtsiolis, svenefftinge and jldec and removed request for JanKoehnlein October 26, 2021 12:36

AlexTugarev mentioned this pull request Oct 26, 2021

Enable "New Workspace" button in Project Configuration without first having to use "Run Prebuild" button #6303

Closed

jldec reviewed Oct 26, 2021

View reviewed changes

AlexTugarev force-pushed the at/new-workspace branch from da3574c to 3accc7f Compare October 27, 2021 15:14

AlexTugarev force-pushed the at/new-workspace branch 3 times, most recently from 9c07e42 to e735b4f Compare October 28, 2021 10:58

AlexTugarev marked this pull request as ready for review October 28, 2021 11:04

roboquat added release-note and removed do-not-merge/work-in-progress labels Oct 28, 2021

roboquat removed the do-not-merge/release-note-label-needed label Oct 28, 2021

AlexTugarev requested a review from jldec October 28, 2021 12:15

jldec suggested changes Oct 28, 2021

View reviewed changes

roboquat assigned jldec Oct 28, 2021

[projects] always enable New Workspace button on config page

ca80f70

AlexTugarev force-pushed the at/new-workspace branch from e735b4f to ca80f70 Compare October 28, 2021 15:11

AlexTugarev requested a review from jldec October 28, 2021 15:11

jldec approved these changes Oct 28, 2021

View reviewed changes

roboquat added the lgtm label Oct 28, 2021

roboquat added the approved label Oct 28, 2021

roboquat merged commit 14a5405 into main Oct 28, 2021

roboquat deleted the at/new-workspace branch October 28, 2021 21:43

jldec mentioned this pull request Oct 28, 2021

New Project flow fails detection on private repos if oauth is fresh #6168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[projects] always enable New Workspace button on config page #6389

[projects] always enable New Workspace button on config page #6389

AlexTugarev commented Oct 25, 2021 •

edited

Loading

svenefftinge commented Oct 26, 2021 •

edited

Loading

AlexTugarev commented Oct 26, 2021

jldec Oct 26, 2021

jldec Oct 28, 2021

AlexTugarev Oct 28, 2021

jldec Oct 26, 2021

AlexTugarev Oct 26, 2021

jldec Oct 26, 2021

jldec commented Oct 26, 2021

jldec commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jldec commented Oct 28, 2021

AlexTugarev commented Oct 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jldec Oct 28, 2021

jldec commented Oct 28, 2021

gptest1 commented Oct 28, 2021

roboquat commented Oct 28, 2021

roboquat commented Oct 28, 2021

jldec commented Oct 28, 2021

		- init: echo 'TODO: build project'
		command: echo 'TODO: start app'`

[projects] always enable New Workspace button on config page #6389

[projects] always enable New Workspace button on config page #6389

Conversation

AlexTugarev commented Oct 25, 2021 • edited Loading

svenefftinge commented Oct 26, 2021 • edited Loading

AlexTugarev commented Oct 26, 2021

jldec Oct 26, 2021

Choose a reason for hiding this comment

jldec Oct 28, 2021

Choose a reason for hiding this comment

AlexTugarev Oct 28, 2021

Choose a reason for hiding this comment

jldec Oct 26, 2021

Choose a reason for hiding this comment

AlexTugarev Oct 26, 2021

Choose a reason for hiding this comment

jldec Oct 26, 2021

Choose a reason for hiding this comment

jldec commented Oct 26, 2021

UI Proposal

jldec commented Oct 27, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Oct 27, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Oct 27, 2021 • edited by werft-gitpod-dev-com bot Loading

AlexTugarev commented Oct 27, 2021 • edited by werft-gitpod-dev-com bot Loading

jldec commented Oct 28, 2021

AlexTugarev commented Oct 28, 2021 • edited by werft-gitpod-dev-com bot Loading

jldec Oct 28, 2021

Choose a reason for hiding this comment

jldec commented Oct 28, 2021

gptest1 commented Oct 28, 2021

roboquat commented Oct 28, 2021

roboquat commented Oct 28, 2021

jldec commented Oct 28, 2021

AlexTugarev commented Oct 25, 2021 •

edited

Loading

svenefftinge commented Oct 26, 2021 •

edited

Loading

jldec commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Oct 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Oct 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading