Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] add additional prebuild state to UI #6424

Merged
merged 2 commits into from
Nov 2, 2021
Merged

[dashboard] add additional prebuild state to UI #6424

merged 2 commits into from
Nov 2, 2021

Conversation

JanKoehnlein
Copy link
Contributor

@JanKoehnlein JanKoehnlein commented Oct 27, 2021 •
edited
Loading

Description

Add an additional state in the UI for prebuilds that are in preparing

Related Issue(s)

Fixes #5904

How to test

Release Notes

improved dashboard UI feedback on pre-build startups

@JanKoehnlein JanKoehnlein marked this pull request as ready for review October 27, 2021 15:39
@JanKoehnlein
Copy link
Contributor Author

@gtsiolis Can you take it for a spin? Do you have any better ideas on the used color and icon?

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 27, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

@gtsiolis gtsiolis mentioned this pull request Oct 27, 2021
Merged
@JanKoehnlein
Copy link
Contributor Author

[dashboard] show PENDING state during entire pre-build pod setup

@roboquat roboquat added size/XS and removed size/S labels Nov 1, 2021
@JanKoehnlein
Copy link
Contributor Author

Thanks for your feedback. Applied it.

@laushinka
Copy link
Contributor

laushinka commented Nov 2, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jk-show-additional-prebuild-phase.3

@laushinka
Copy link
Contributor

@JanKoehnlein Should the preview env already have a GitHub app working without additional work by the reviewer? Or should these steps be done?
(Also, I followed that Notion page for my PR but didn't manage to get it working)

@JanKoehnlein
Copy link
Contributor Author

@laushinka You should be able to test with a GitLab project.

@laushinka
Copy link
Contributor

laushinka commented Nov 2, 2021 •
edited
Loading

I don't have much knowledge re Prebuilds, so I'm actually not sure where Running ends and Ready starts. Is it supposed to show "Running" in this stage?

Screenshot 2021-11-02 at 11 37 30

@JanKoehnlein
Copy link
Contributor Author

@laushinka yes that's expected.

@laushinka
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Nov 2, 2021
@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

LGTM label has been added.

Git tree hash: 999f6bde0eaf60fdaa6587459ffab6e65b303d8c

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laushinka

Associated issue: #5904

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 8e41a03 into main Nov 2, 2021
@roboquat roboquat deleted the jk/show-additional-prebuild-phase branch November 2, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees

@laushinka laushinka

Labels
approved component: dashboard release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinguish between prebuild "Running" and "Preparing"
4 participants
@JanKoehnlein @gtsiolis @laushinka @roboquat