Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager]: handle if IdeImage not included on the request spec #6453

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

In WS Manager, if the IdeImage is not, the application panics. This happens when using image-builder-mk3

Related Issue(s)

Fixes #

How to test

Release Notes

[ws-manager]: Add check for IdeImage not being present in the spec

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/L labels Oct 29, 2021
@mrsimonemms mrsimonemms requested a review from a team October 29, 2021 10:48
@mrsimonemms
Copy link
Contributor Author

/assign @csweichel

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #6453 (f7c2ae8) into main (d75a880) will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6453      +/-   ##
==========================================
+ Coverage   36.28%   37.03%   +0.75%     
==========================================
  Files          21       19       -2     
  Lines        4688     4520     -168     
==========================================
- Hits         1701     1674      -27     
+ Misses       2851     2713     -138     
+ Partials      136      133       -3     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 37.03% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/terminal/terminal.go 63.27% <0.00%> (-0.93%) ⬇️
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/ports/ports.go 61.92% <0.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75a880...f7c2ae8. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Oct 29, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64a493ddb0b3b250d347f4235b9c447ddd8ba97f

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit d61569b into main Oct 29, 2021
@roboquat roboquat deleted the sje/ws-manager-ide-image-fix branch October 29, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants