[ws-proxy] Decouple ws-proxy from ws-manager #6462

aledbf · 2021-10-30T12:30:29Z

Description

This refactoring removes the use of services to export workspace ports, using the pod directly instead.
Changing the default behavior, we do not rely on DNS to route traffic to the workspace (ws-..cluster.local:) anymore, and instead, we use the pod IP address. This removes issues related to DNS queries, timeous, or UDP connection tracking (iptables).
A side effect of this change is kube-dns do not store information about the workspaces (services) anymore. This will reduce the load on that component.

Changes:

Decouple ws-proxy from ws-manager
Remove GRPC from ws-proxy
Workspace details are extracted from pods
Workspace exposed ports are published on the pod itself (annotation gitpod/exposedPorts)
There are no more workspace services

Related Issue(s)

fixes #6441
fixes #6325

How to test

Open a workspace. The improvement of speed to expose ports should be noticeable.
Executing kubectl get svc should not return any services related to workspaces.

Things to test:

start a server in the workspace, expose the port and access it
stop the server and see the port go away
test local VS code and auto-tunneling
try experimentalNetwork: true in the .gitpod.yml

Release Notes

[ws-proxy] Decouple ws-proxy from ws-manager

aledbf · 2021-10-30T12:37:41Z

/werft run

👍 started the job as gitpod-build-aledbf-wsproxy.2

codecov · 2021-10-30T15:36:40Z

Codecov Report

Merging #6462 (f016151) into main (fc5ba3d) will increase coverage by 30.42%.
The diff coverage is 60.36%.

❗ Current head f016151 differs from pull request most recent head 6c31254. Consider uploading reports for the commit 6c31254 to get more accurate results

@@            Coverage Diff             @@
##            main    #6462       +/-   ##
==========================================
+ Coverage   7.09%   37.51%   +30.42%     
==========================================
  Files         10       19        +9     
  Lines        930     4555     +3625     
==========================================
+ Hits          66     1709     +1643     
- Misses       862     2713     +1851     
- Partials       2      133      +131

Flag	Coverage Δ
components-supervisor-app	`37.51% <60.36%> (?)`
installer-raw-app	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/supervisor/pkg/dropwriter/dropwriter.go	`73.46% <ø> (ø)`
components/supervisor/pkg/ports/exposed-ports.go	`0.00% <0.00%> (ø)`
components/supervisor/pkg/ports/ports-config.go	`80.00% <ø> (ø)`
components/supervisor/pkg/ports/tunnel.go	`63.63% <0.00%> (ø)`
components/supervisor/pkg/supervisor/config.go	`4.23% <ø> (ø)`
components/supervisor/pkg/supervisor/git.go	`0.00% <ø> (ø)`
components/supervisor/pkg/supervisor/services.go	`23.82% <0.00%> (ø)`
components/supervisor/pkg/supervisor/ssh.go	`0.00% <0.00%> (ø)`
components/supervisor/pkg/supervisor/supervisor.go	`6.19% <0.00%> (ø)`
components/supervisor/pkg/supervisor/user.go	`33.12% <ø> (ø)`
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ea972...6c31254. Read the comment docs.

aledbf · 2021-11-01T10:36:39Z

/werft run

👍 started the job as gitpod-build-aledbf-wsproxy.24

components/ws-manager-api/go/exposed_ports.go

components/ws-manager/pkg/manager/testdata/controlPort_changeVisibility.golden

components/ws-manager/pkg/manager/testdata/status_cannotPull_004_CREATING00.golden

components/ws-manager/pkg/manager/testdata/status_failedTheiaMount_PENDING00.golden

csweichel · 2021-11-02T07:44:07Z

components/ws-proxy/pkg/proxy/config.go

-	ServiceTemplate     string `json:"serviceTemplate"`
-	PortServiceTemplate string `json:"portServiceTemplate"`


aledbf · 2021-11-02T11:19:52Z

/werft run

👍 started the job as gitpod-build-aledbf-wsproxy.48

aledbf · 2021-11-02T11:24:28Z

/werft run

👍 started the job as gitpod-build-aledbf-wsproxy.49

csweichel · 2021-11-04T13:31:58Z

/hold cancel

csweichel · 2021-11-04T18:21:37Z

Tested these things:

start a server in the workspace, expose the port and access it
stop the server and see the port go away
test local VS code and auto-tunneling
try experimentalNetwork: true in the .gitpod.yml

All worked like a treat, and much quicker than before ✅

csweichel · 2021-11-04T18:21:42Z

/approve

JanKoehnlein · 2021-11-04T20:00:43Z

/lgtm

Codewise, I admit I didn't test

JanKoehnlein · 2021-11-04T20:10:28Z

/lgtm

roboquat · 2021-11-04T20:10:31Z

LGTM label has been added.

Git tree hash: c6f3fd7c2a67d17a744a3d2f2d21278ecb55c413

corneliusludmann · 2021-11-05T09:32:29Z

/approve

looks good and works like a charm! 🚀

roboquat · 2021-11-05T09:32:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann, csweichel, JanKoehnlein

Associated issue: #6441

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JanKoehnlein,corneliusludmann,csweichel]
~~components/common-go/OWNERS~~ [csweichel]
~~components/content-service-api/OWNERS~~ [csweichel]
~~components/gitpod-protocol/OWNERS~~ [JanKoehnlein]
~~components/image-builder-api/OWNERS~~ [csweichel]
~~components/local-app-api/OWNERS~~ [csweichel]
~~components/registry-facade-api/OWNERS~~ [csweichel]
~~components/server/OWNERS~~ [JanKoehnlein]
~~components/supervisor/OWNERS~~ [corneliusludmann]
~~components/supervisor-api/OWNERS~~ [csweichel]
~~components/ws-daemon-api/OWNERS~~ [csweichel]
~~components/ws-manager/OWNERS~~ [csweichel]
~~components/ws-manager-api/OWNERS~~ [csweichel]
~~components/ws-manager-bridge/OWNERS~~ [JanKoehnlein]
~~components/ws-manager-bridge-api/OWNERS~~ [csweichel]
~~components/ws-proxy/OWNERS~~ [csweichel]
~~dev/loadgen/OWNERS~~ [csweichel]
~~installer/OWNERS~~ [csweichel]
~~operations/workspace/deployment/OWNERS~~ [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed team: workspace Issue belongs to the Workspace team size/XXL labels Oct 30, 2021

aledbf force-pushed the aledbf/wsproxy branch from 7525fcf to 40b87e6 Compare October 30, 2021 16:52

roboquat added the team: webapp Issue belongs to the WebApp team label Oct 30, 2021

aledbf force-pushed the aledbf/wsproxy branch from 6be68b6 to 64f4bc9 Compare October 30, 2021 17:47

aledbf requested a review from csweichel October 30, 2021 17:48

aledbf assigned csweichel Oct 30, 2021

aledbf force-pushed the aledbf/wsproxy branch 5 times, most recently from 6e2d4c5 to 3b3f2d1 Compare October 30, 2021 20:09

aledbf changed the title ~~WIP [ws-proxy] Decouple ws-proxy from ws-manager~~ [ws-proxy] Decouple ws-proxy from ws-manager Oct 30, 2021

aledbf force-pushed the aledbf/wsproxy branch from 3b3f2d1 to 438daf9 Compare November 1, 2021 11:03

roboquat added the team: IDE label Nov 1, 2021

aledbf force-pushed the aledbf/wsproxy branch 5 times, most recently from b8afa3f to db25bbd Compare November 1, 2021 19:24

csweichel reviewed Nov 2, 2021

View reviewed changes

aledbf force-pushed the aledbf/wsproxy branch 2 times, most recently from 1f8928b to 6e5b3f8 Compare November 2, 2021 10:25

aledbf added 7 commits November 4, 2021 09:15

Update test golden files

23fd4ba

Refactor ws-manager to stop using services

a6af02b

Refactor helm chart

d306085

Add ExposedPorts message and remove Target and GlobalPort

0e8be81

Update go modules

8c3d888

Refactor supervisor port exposure

f7a85d6

Fix readNetTCPFile

6c31254

aledbf force-pushed the aledbf/wsproxy branch from ce67576 to 6c31254 Compare November 4, 2021 12:18

roboquat removed the do-not-merge/hold label Nov 4, 2021

aledbf requested review from geropl and akosyakov November 4, 2021 16:06

roboquat assigned JanKoehnlein Nov 4, 2021

roboquat added the lgtm label Nov 4, 2021

roboquat added the approved label Nov 5, 2021

roboquat merged commit fe5bc40 into main Nov 5, 2021

roboquat deleted the aledbf/wsproxy branch November 5, 2021 09:33

aledbf mentioned this pull request Nov 8, 2021

Used the instructions from this repo but can't run docker in workspace gitpod-io/gitpod-eks-guide#25

Closed

roboquat added the deployed: webapp Meta team change is running in production label Nov 19, 2021

jeanp413 mentioned this pull request Dec 14, 2021

[gitpod] enable telemetry for testing gitpod-io/openvscode-server#257

Merged

aledbf mentioned this pull request Jan 27, 2022

Enable NodeLocal DNSCache #7885

Closed

aledbf restored the aledbf/wsproxy branch October 13, 2022 17:30

aledbf deleted the aledbf/wsproxy branch December 8, 2022 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ws-proxy] Decouple ws-proxy from ws-manager #6462

[ws-proxy] Decouple ws-proxy from ws-manager #6462

aledbf commented Oct 30, 2021 •

edited by csweichel

Loading

aledbf commented Oct 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Oct 30, 2021 •

edited

Loading

aledbf commented Nov 1, 2021 •

edited by werft-gitpod-dev-com bot

Loading

csweichel Nov 2, 2021

aledbf commented Nov 2, 2021 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Nov 2, 2021 •

edited by werft-gitpod-dev-com bot

Loading

csweichel commented Nov 4, 2021

csweichel commented Nov 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading

csweichel commented Nov 4, 2021

JanKoehnlein commented Nov 4, 2021

JanKoehnlein commented Nov 4, 2021

roboquat commented Nov 4, 2021

corneliusludmann commented Nov 5, 2021

roboquat commented Nov 5, 2021

		ServiceTemplate string `json:"serviceTemplate"`
		PortServiceTemplate string `json:"portServiceTemplate"`

[ws-proxy] Decouple ws-proxy from ws-manager #6462

[ws-proxy] Decouple ws-proxy from ws-manager #6462

Conversation

aledbf commented Oct 30, 2021 • edited by csweichel Loading

Description

Related Issue(s)

How to test

Release Notes

aledbf commented Oct 30, 2021 • edited by werft-gitpod-dev-com bot Loading

codecov bot commented Oct 30, 2021 • edited Loading

Codecov Report

aledbf commented Nov 1, 2021 • edited by werft-gitpod-dev-com bot Loading

csweichel Nov 2, 2021

Choose a reason for hiding this comment

aledbf commented Nov 2, 2021 • edited by werft-gitpod-dev-com bot Loading

aledbf commented Nov 2, 2021 • edited by werft-gitpod-dev-com bot Loading

csweichel commented Nov 4, 2021

csweichel commented Nov 4, 2021 • edited by werft-gitpod-dev-com bot Loading

csweichel commented Nov 4, 2021

JanKoehnlein commented Nov 4, 2021

JanKoehnlein commented Nov 4, 2021

roboquat commented Nov 4, 2021

corneliusludmann commented Nov 5, 2021

roboquat commented Nov 5, 2021

aledbf commented Oct 30, 2021 •

edited by csweichel

Loading

aledbf commented Oct 30, 2021 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Oct 30, 2021 •

edited

Loading

aledbf commented Nov 1, 2021 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Nov 2, 2021 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Nov 2, 2021 •

edited by werft-gitpod-dev-com bot

Loading

csweichel commented Nov 4, 2021 •

edited by werft-gitpod-dev-com bot

Loading