Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspacekit] Make resolv.conf writeable #6467

Merged
merged 1 commit into from
Oct 31, 2021
Merged

[workspacekit] Make resolv.conf writeable #6467

merged 1 commit into from
Oct 31, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Oct 31, 2021

Description

This change makes /etc/resolv.conf writeable by copying it over from the Kubernetes container, rather than bind-mounting it.

image

Related Issue(s)

Fixes #6457

How to test

  • start a workspace
  • make changes to /etc/resolv.conf and save the file

better yet:

Release Notes

`/etc/resolv.conf` is now writeable

Documentation

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #6467 (7f8b3cb) into main (21fda09) will decrease coverage by 11.96%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6467       +/-   ##
==========================================
- Coverage   19.04%   7.08%   -11.97%     
==========================================
  Files           2       4        +2     
  Lines         168     720      +552     
==========================================
+ Hits           32      51       +19     
- Misses        134     666      +532     
- Partials        2       3        +1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-workspacekit-app 7.08% <6.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/workspacekit/cmd/rings.go 6.45% <6.66%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/workspacekit/cmd/lift.go 18.18% <0.00%> (ø)
components/workspacekit/cmd/nsenter.go 25.00% <0.00%> (ø)
components/workspacekit/cmd/root.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fda09...7f8b3cb. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Oct 31, 2021

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9767d484e299716db354460be9b30e0fdf67a3db

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #6457

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit ec744db into main Oct 31, 2021
@roboquat roboquat deleted the cw/fix-6457 branch October 31, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tailscale] MagicDNS doesn't work
3 participants