-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GCP CloudSQL proxy #6606
Conversation
ac65609
to
7410bb8
Compare
Codecov Report
@@ Coverage Diff @@
## main #6606 +/- ##
==========================================
- Coverage 19.04% 6.00% -13.05%
==========================================
Files 2 12 +10
Lines 168 1116 +948
==========================================
+ Hits 32 67 +35
- Misses 134 1048 +914
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7410bb8
to
ee84161
Compare
ee84161
to
2662388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be cool to have a secret validation in place akin to the certificates
check.
That said, both comments in this PR can come in later and don't need to be part of this PR. I'd be happy to merge this way (just remove the hold), or add to this PR.
Did not actually test change, but code lgtm.
/hold
/lgtm
|
||
-- must be idempotent | ||
|
||
CREATE DATABASE IF NOT EXISTS `gitpod-sessions` CHARSET utf8mb4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could - not necessarily in this PR - move this script (these scripts) to something like pkg/components/database/init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible, but the init scripts are subtly different.
LGTM label has been added. Git tree hash: ed4a33285ff24abfadf954dd2a0c7b267ed75a55
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6562 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Description
Support GCP CloudSQL. Also change the config so the external DB is provider-agnostic
Related Issue(s)
Fixes #6562
How to test
Set up MySQL DB in GCP
Create secret with following keys:
credentials.json
- service account to access DBencryptionKeys
- use[{"name": "general","version": 1,"primary": true,"material": "4uGh1q8y2DYryJwrVMHs0kWXJlqvHWWt/KJuNi04edI="}]
username
- whatever you set up in GCPpassword
- dittoChange config to:
Release Notes
Documentation