Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: secret validation #6702

Merged
merged 2 commits into from
Nov 16, 2021
Merged

[installer]: secret validation #6702

merged 2 commits into from
Nov 16, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

  • Add container registry and cloudsql secret checks to the cluster validation.
  • Update the validation output so it changes the status if check returns "not ok" status

Related Issue(s)

Fixes #6627

How to test

go run . validate cluster --kubeconfig ~/.kube/config --config ./example-config.yaml and update your config so it expects external database/registry

Release Notes

Add container registry and database secret checks

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/S labels Nov 15, 2021
@mrsimonemms
Copy link
Contributor Author

/assign @csweichel

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #6702 (4ac29cd) into main (47d4ac5) will decrease coverage by 30.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6702       +/-   ##
==========================================
- Coverage   36.69%   6.16%   -30.53%     
==========================================
  Files          22      12       -10     
  Lines        2363    1086     -1277     
==========================================
- Hits          867      67      -800     
+ Misses       1443    1018      -425     
+ Partials       53       1       -52     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-proxy-app ?
installer-raw-app 6.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/ws-proxy/pkg/proxy/config.go
components/ws-proxy/pkg/proxy/cookies.go
components/ws-proxy/pkg/proxy/workspacerouter.go
components/ws-proxy/pkg/proxy/routes.go
components/ws-proxy/pkg/proxy/infoprovider.go
components/ws-proxy/pkg/proxy/proxy.go
components/ws-proxy/pkg/proxy/pass.go
components/local-app/pkg/auth/auth.go
components/ws-proxy/pkg/proxy/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d4ac5...4ac29cd. Read the comment docs.

@mrsimonemms mrsimonemms changed the title Sje/cert validation [installer]: secret validation Nov 16, 2021
@roboquat roboquat added the lgtm label Nov 16, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd7e89d8e86542766dabca884bba949a93ceedc8

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f3ecc7f into main Nov 16, 2021
@roboquat roboquat deleted the sje/cert-validation branch November 16, 2021 09:49
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: validate that external certificates contain the correct keys/structure
3 participants