Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: fix jaeger operator misconfiguration #6760

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

Fixed copy/pasta errors in the Jaeger operator

Related Issue(s)

Fixes #6759

How to test

Update the config:

observability:
  logLevel: info
  tracing:
    endpoint: http://jaeger-collector:14268/api/traces

Deploy Jaeger, changing the nodeAffinity key to gitpod.io/workload_meta

Create a port forwarder to the jaeger deployment kubectl port-forward jaeger-5945545574-g5jgc 3000:16686.

Go to localhost:3000 and check that there are traces flowing in

Release Notes

[installer]: fix jaeger operator misconfiguration

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/S labels Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #6760 (10e0f9b) into main (399fd2b) will decrease coverage by 12.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6760       +/-   ##
==========================================
- Coverage   19.04%   6.16%   -12.88%     
==========================================
  Files           2      12       +10     
  Lines         168    1086      +918     
==========================================
+ Hits           32      67       +35     
- Misses        134    1018      +884     
+ Partials        2       1        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/common/display.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.74% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399fd2b...10e0f9b. Read the comment docs.

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrsimonemms just one question, lemme know whatcha think?

installer/pkg/components/jaeger-operator/helm.go Outdated Show resolved Hide resolved
@kylos101
Copy link
Contributor

/approve

@mrsimonemms
Copy link
Contributor Author

/approve no-issue

@kylos101
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d73006177635f65b7d38af9fa7087eafc0033656

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kylos101, MrSimonEmms

Associated issue: #6759

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4ba97cc into main Nov 18, 2021
@roboquat roboquat deleted the sje/installer-jaeger-operator-fixes branch November 18, 2021 14:37
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer]: fix jaeger-operator misconfigs
3 participants