Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced nodepool 3 with 0 for prev-envs #6780

Merged
merged 1 commit into from
Nov 19, 2021
Merged

replaced nodepool 3 with 0 for prev-envs #6780

merged 1 commit into from
Nov 19, 2021

Conversation

fullmetalrooster
Copy link
Contributor

Description

The nodepool workspace-3 has problem with the networking. This replaces it with a nodepool that has been recently updated.

@roboquat
Copy link
Contributor

@wulfthimm: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ebe08347955ec9ca9217f4fbec7bb76d5e3ad3ff

@geropl
Copy link
Member

geropl commented Nov 18, 2021

/approve no-issue

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #6780 (9e5b2a5) into main (4ba97cc) will decrease coverage by 1.72%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #6780      +/-   ##
========================================
- Coverage   7.89%   6.16%   -1.73%     
========================================
  Files         14      12       -2     
  Lines       1254    1086     -168     
========================================
- Hits          99      67      -32     
+ Misses      1152    1018     -134     
+ Partials       3       1       -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba97cc...9e5b2a5. Read the comment docs.

@geropl
Copy link
Member

geropl commented Nov 19, 2021

/approve no-issue

This is weird: Only reason I can imagine this happened is because of the GH UI was out-of- sync.
image

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a53a87b into main Nov 19, 2021
@roboquat roboquat deleted the wth/repl branch November 19, 2021 07:44
@iQQBot
Copy link
Contributor

iQQBot commented Nov 19, 2021

And another thins is there is no node fit gitpod.io/workspace_0 @geropl

@geropl
Copy link
Member

geropl commented Nov 19, 2021

@iQQBot I assume there is a nodepool that autoscales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants