Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Add more actions to workspace ready page #6847

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

corneliusludmann
Copy link
Contributor

Description

This PR adds more actions to the “Your Workspace is Ready” page and adds a hint to the preferences proposed by Lou.

image

image

Related Issue(s)

Fixes #6769 and fixes #6841

How to test

Open a workspace with a desktop IDE enabled in the preferences and check that all links are working.

Release Notes

The “Your Workspace is Ready” page for desktop IDEs now has “Stop Workspace” and “Go to Dashboard” actions.

Documentation

@loujaybee Any docs updates needed?

@JanKoehnlein
Copy link
Contributor

/lgtm

Sorry for the late review

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c53315b8ba69a2e4eed4363a8ab614ce09f654b

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #6769

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 7e92f60 into main Nov 24, 2021
@roboquat roboquat deleted the clu/return-to-dashboard-6841 branch November 24, 2021 13:00
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production release-note size/M team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
3 participants