Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: remove jaeger operator external #6964

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Nov 29, 2021

Description

The jaegerOperator external object doesn't make any sense in it's current form. The Jaeger operators are all about installing Custom Resource Definitions and are not a resource that can be communicated with, which is what the external objects have been used for

Release Notes

Remove jaeger operator external

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team labels Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #6964 (68795f4) into main (83118bf) will decrease coverage by 13.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6964       +/-   ##
==========================================
- Coverage   19.04%   5.84%   -13.21%     
==========================================
  Files           2      13       +11     
  Lines         168    1147      +979     
==========================================
+ Hits           32      67       +35     
- Misses        134    1079      +945     
+ Partials        2       1        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <0.00%> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <0.00%> (ø)
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83118bf...68795f4. Read the comment docs.

@princerachit
Copy link
Contributor

Does this require any change in our sample config files for installer?

@mrsimonemms
Copy link
Contributor Author

@princerachit my expectation is no. To the best of my knowledge, this is something that has never been used anywhere - I discovered this yesterday with @kylos101 with him going through his core-dev work

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13bb949f162fac06dbd32203a191aaceb33fdd4f

@gitpod-io gitpod-io deleted a comment from roboquat Dec 1, 2021
@roboquat roboquat merged commit 4c18956 into main Dec 1, 2021
@roboquat roboquat deleted the sje/remove-jaeger-operator-external branch December 1, 2021 11:04
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants