Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jk/api-telemetry #7000

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Jk/api-telemetry #7000

merged 1 commit into from
Dec 8, 2021

Conversation

JanKoehnlein
Copy link
Contributor

Minor cleanup

Base automatically changed from gpl/api-telemetry to main December 1, 2021 16:34
@roboquat roboquat added size/XXL and removed size/S labels Dec 1, 2021
geropl
geropl approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat added the lgtm label Dec 1, 2021
@roboquat
Copy link
Contributor

roboquat commented Dec 1, 2021

LGTM label has been added.

Git tree hash: 634e98fc6ffb9d468dd530707aad0deb51a7f6f5

@geropl
Copy link
Member

geropl commented Dec 1, 2021

/approve no-issue

@JanKoehnlein
Copy link
Contributor Author

@geropl I had to rebase. Could you /lgtm again?

@roboquat roboquat added size/XS and removed size/S labels Dec 7, 2021
@laushinka
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Dec 8, 2021
@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2021

LGTM label has been added.

Git tree hash: baa868469216bc12ca47fe1524732b0386bad27d

@roboquat
Copy link
Contributor

roboquat commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, laushinka

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 44c11d1 into main Dec 8, 2021
@roboquat roboquat deleted the jk/api-telemetry branch December 8, 2021 08:44
@geropl
Copy link
Member

geropl commented Dec 8, 2021

Thx @laushinka !

Sorry @JanKoehnlein , thought I already /lgtm this one 😕

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@laushinka laushinka

@geropl geropl

Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JanKoehnlein @roboquat @geropl @laushinka