[image-builder] Accept "familiar" base image refs #7045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note
team: workspace
|
/lgtm |
|
LGTM label has been added. Git tree hash: 56f0962c2f2df1d56b4d6665840061b3661211cc
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf Associated issue: #7043 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
csweichel
added
deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes workspaces work again which use a digested familiar reference as base image, e.g.
jelaniwoods/appdev2021-base-rails@sha256:91427ecf043c8cdd8040bbd3626eb9bbbf3bee99d44ed3d1281504f71681d661Related Issue(s)
Fixes #7043
How to test
Open https://github.com/appdev-projects/base-rails/tree/5e42ef0d03bcc267baf7f13b47f3b7f3ad71dc32 in a workspace. If it opens we're good.
Release Notes
Documentation