-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separator fix #7065
separator fix #7065
Conversation
/werft run 👍 started the job as gitpod-build-workspaces-overflow-fix-fork.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@bigint: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @laushinka |
Hi @krystofex, thanks for the contribution! Could you describe what the problem was before? Maybe in a screenshot? :) |
@laushinka If you visit https://gitpod.io/workspaces you can see the x scrollbar overflow the screen But this PR helps us to remove the buggy x-overflow |
Works as advertised! Thanks @krystofex :) /lgtm |
LGTM label has been added. Git tree hash: e6fec37551af11d2816700bc9e99c50f657c2627
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigint, laushinka Associated issue requirement bypassed by: laushinka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -5,5 +5,5 @@ | |||
*/ | |||
|
|||
export default function Separator() { | |||
return <div className="border-gray-200 dark:border-gray-800 border-b absolute left-0 w-screen"></div>; | |||
return <div className="border-gray-200 dark:border-gray-800 border-b absolute left-0 w-full"></div>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Just seeing this now -- many thanks @krystofex @filiptronicek @bigint and @laushinka! 🎉 💯
Description
Change separator component class
Related Issue(s)
x-overflow on /workspaces page
Release Notes