Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separator fix #7065

Merged
merged 1 commit into from
Dec 6, 2021
Merged

separator fix #7065

merged 1 commit into from
Dec 6, 2021

Conversation

krystxf
Copy link
Contributor

@krystxf krystxf commented Dec 5, 2021

Description

Change separator component class

Related Issue(s)

x-overflow on /workspaces page

Release Notes

Fix x-overflow on the /workspaces page

@filiptronicek
Copy link
Member

filiptronicek commented Dec 5, 2021

/werft run

👍 started the job as gitpod-build-workspaces-overflow-fix-fork.0

@bigint
Copy link

bigint commented Dec 5, 2021

Screenshot 2021-12-05 at 4 46 23 PM

Perfect I can verify x-overflow is fixed, great job 👏🏻

Copy link

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@roboquat
Copy link
Contributor

roboquat commented Dec 5, 2021

@bigint: changing LGTM is restricted to collaborators

In response to this:

LGTM 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krystxf
Copy link
Contributor Author

krystxf commented Dec 5, 2021

/assign @laushinka

@laushinka
Copy link
Contributor

Hi @krystofex, thanks for the contribution! Could you describe what the problem was before? Maybe in a screenshot? :)

@bigint
Copy link

bigint commented Dec 6, 2021

@laushinka If you visit https://gitpod.io/workspaces you can see the x scrollbar overflow the screen

Screenshot 2021-12-06 at 6 00 56 PM

But this PR helps us to remove the buggy x-overflow

#7065 (comment)

@laushinka
Copy link
Contributor

Works as advertised! Thanks @krystofex :)

/lgtm

@roboquat roboquat added the lgtm label Dec 6, 2021
@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

LGTM label has been added.

Git tree hash: e6fec37551af11d2816700bc9e99c50f657c2627

@laushinka
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigint, laushinka

Associated issue requirement bypassed by: laushinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 8d8f5b5 into gitpod-io:main Dec 6, 2021
@@ -5,5 +5,5 @@
*/

export default function Separator() {
return <div className="border-gray-200 dark:border-gray-800 border-b absolute left-0 w-screen"></div>;
return <div className="border-gray-200 dark:border-gray-800 border-b absolute left-0 w-full"></div>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Just seeing this now -- many thanks @krystofex @filiptronicek @bigint and @laushinka! 🎉 💯

@krystxf krystxf deleted the workspaces-overflow-fix branch December 7, 2021 02:20
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved community-contribution component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants