[installer]: separate server and IDE components

[mrsimonemms]

Description

As the server component is currently structured, it doesn't accurately reflect the team ownership. The server component is owned by @gitpod-io/engineering-meta and the ide-configmap is owned by the @gitpod-io/engineering-ide team.

This separates out the ide-configmap into it's own package underneath server with the corrected ownership

Related Issue(s)

Fixes #7060

How to test

Run a deployment via the Installer as normal. There are no changes to the way the Installer behaves, just code structure changes

Release Notes

[installer]: separate server and IDE components

Documentation

[codecov]

Codecov Report

Merging #7200 (e5fb617) into main (300a805) will not change coverage.
The diff coverage is n/a.

❗ Current head e5fb617 differs from pull request most recent head a2d9783. Consider uploading reports for the commit a2d9783 to get more accurate results

@@          Coverage Diff          @@
##            main   #7200   +/-   ##
=====================================
  Coverage   5.76%   5.76%           
=====================================
  Files         13      13           
  Lines       1162    1162           
=====================================
  Hits          67      67           
  Misses      1094    1094           
  Partials       1       1           

Flag	Coverage Δ
installer-raw-app	5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced67ae...a2d9783. Read the comment docs.

[mrsimonemms]

/hold

I would like to get approval from all three teams in the approvals as it affects them all

[akosyakov]

@iQQBot Could you review it please? 🙏

[iQQBot]

@iQQBot Could you review it please? 🙏

Yes

[JanKoehnlein]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: a24815ca83db8bdbcfbb09dfdb9344bc602d0525

[iQQBot]

LGTM, just change path, no changes to other cores
@akosyakov I am not owner of IDE team

[mrsimonemms]

Only question remains - should there be multiple ownerships on the versions folder?. For this, it makes sense to me as this is the one part that really is owned by everyone.

But equally, I can see the argument that this should be owned by the owner of the component as the custodians/maintainers of the Installer.

Thoughts @svenefftinge @csweichel @corneliusludmann et al

[corneliusludmann]

Only question remains - should there be multiple ownerships on the versions folder?. For this, it makes sense to me as this is the one part that really is owned by everyone.

Ideally, we would find a way to split this file and have a separate versions.go file for each team. However, this seems to involve a lot of effort, doesn't it? That's why I think it's a feasible compromise that all teams are owners of this file.

[mrsimonemms]

@corneliusludmann yes, it would probably require reworking of the whole version generator in werft, which could well have unforeseen consequences. It also seems a lot of work when could just have multiple owners in there

[corneliusludmann]

it would probably require reworking of the whole version generator in werft

I think it's not that worse. We “just” need to change the values of meta-data.helm-component in the BUILD.yaml files of all the components. E.g. change

gitpod/components/server/BUILD.yaml

Lines 34 to 35 in 28bf0e6

	metadata:
	helm-component: server

to helm-component: meta.server and

gitpod/components/ide/jetbrains/image/BUILD.yaml

Lines 25 to 26 in 74d2f69

	metadata:
	helm-component: workspace.desktopIdeImages.intellij

to helm-component: ide.desktopIdeImages.intellij.

Then, everything below meta in the versions.yaml would go to the meta team and everything below ide team would go to the IDE team etc.

However, this change does not make sense as long as we support the helm charts because that would break them. But we could think about making this change once we stop supporting the helm charts.

For now, multiple owners of the versions.go file would be fine, in my opinion.

[iQQBot]

Hi @mrsimonemms I create a PR for cleanup deprecated ide-config, if you approve it will merge into this branch
#7212

[iQQBot]

LTGM

[roboquat]

LGTM label has been added.

Git tree hash: 4fff918a745a846abc396f70cdd0e17551da8306

[jeanp413]

@iQQBot I think you should also cleanup chart/templates/server-ide-configmap.yaml 👀

[iQQBot]

@iQQBot I think you should also cleanup chart/templates/server-ide-configmap.yaml 👀

#7211 already done in another PR

[mrsimonemms]

@jeanp413 that shouldn't be part of this PR though

[iQQBot]

/verify-owners

[iQQBot]

I think this PR should be merged as soon as possible

[mrsimonemms]

/unhold
/approve

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot, JanKoehnlein, MrSimonEmms

Associated issue: #7060

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• installer/OWNERS [MrSimonEmms]
• installer/pkg/components/server/OWNERS [JanKoehnlein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment