Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[observability] Team Workspace / Success Criteria dashboard -> no data #7354

Merged
merged 2 commits into from
Dec 23, 2021
Merged

[observability] Team Workspace / Success Criteria dashboard -> no data #7354

merged 2 commits into from
Dec 23, 2021

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Dec 23, 2021 •
edited
Loading

Description

Success critiera dashboard for Team Workspace shows no data on page load

Related Issue(s)

Fixes #7335

How to test

To recreate the issue:
Browse here

To recreate the fix:

  1. Open a Gitpod workspace from this PR's branch
  2. kubectl port-forward svc/grafana 3000:3000
  3. Start a workspace from here
  4. Browse to Grafana and view the results

Or see the fix in action here:

Fix for Team Workspace / Success Criteria dashboard -> no data #7335 - Watch Video



Release Notes

Fix Team Workspace Success Criteria dashboard

@aledbf
Copy link
Member

aledbf commented Dec 23, 2021

/lgtm

@roboquat roboquat added the lgtm label Dec 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: eb4fd9f5479b55261d354449ac89f40fcc48122c

@kylos101
Fixes #7335
36de3f0 
Handle "no data" by adding 'on() vector(0)' to each numerator
Relies on new variable $datasource
Also fixes legend for workspace startup panel
When exporting from Grafana, disable "export for sharing externally"
@kylos101
Helm is needed to support Observability
925031d
@roboquat roboquat added team: devx and removed lgtm labels Dec 23, 2021
@kylos101 kylos101 changed the title Kyleb/ws dashboard [observability] Team Workspace / Success Criteria dashboard -> no data Dec 23, 2021
@kylos101 kylos101 marked this pull request as ready for review December 23, 2021 18:00
@kylos101
Copy link
Contributor Author

@aledbf this is all set now, I squashed it and added a Loom video so you can see how this is working in core-dev. 😄

@aledbf
Copy link
Member

aledbf commented Dec 23, 2021

/lgtm

@roboquat roboquat added the lgtm label Dec 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb9b8c1ea6b33fed539137895dc096d8d23f21c6

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #7335

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 821d463 into main Dec 23, 2021
@roboquat roboquat deleted the kyleb/ws-dashboard branch December 23, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved release-note size/M team: devx team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[observability] Team Workspace / Success Criteria dashboard -> no data
3 participants
@kylos101 @aledbf @roboquat