Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove theia IDE #7395

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Remove theia IDE #7395

merged 1 commit into from
Jan 3, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 30, 2021

Release Notes

Remove theia IDE

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #7395 (a70a930) into main (4e2de28) will decrease coverage by 16.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7395       +/-   ##
==========================================
- Coverage   22.33%   5.76%   -16.58%     
==========================================
  Files          22      13        -9     
  Lines        2431    1162     -1269     
==========================================
- Hits          543      67      -476     
+ Misses       1850    1094      -756     
+ Partials       38       1       -37     
Flag Coverage Δ
components-ee-agent-smith-app ?
components-ee-agent-smith-lib ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ee/agent-smith/pkg/agent/egress.go
...onents/ee/agent-smith/pkg/classifier/classifier.go
components/local-app/pkg/auth/auth.go
components/ee/agent-smith/pkg/detector/proc.go
components/local-app/pkg/auth/pkce.go
components/ee/agent-smith/pkg/agent/agent.go
...mponents/ee/agent-smith/pkg/classifier/sinature.go
components/ee/agent-smith/pkg/agent/actions.go
components/ee/agent-smith/pkg/agent/metrics.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c09f7...a70a930. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Dec 30, 2021

/assign @akosyakov

@iQQBot
Copy link
Contributor

iQQBot commented Dec 30, 2021

/lgtm
/approve no-issue
/hold
wait @akosyakov to see

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac89023e187b6d557bbf37ecad70fe72b2dab66f

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iQQBot

Associated issue requirement bypassed by: iQQBot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akosyakov
Copy link
Member

akosyakov commented Jan 3, 2022

/werft run

👍 started the job as gitpod-build-aledbf-theia.1

@akosyakov
Copy link
Member

/unhold

@roboquat roboquat merged commit d7469c4 into main Jan 3, 2022
@roboquat roboquat deleted the aledbf/theia branch January 3, 2022 08:20
@jeanp413
Copy link
Member

jeanp413 commented Jan 5, 2022

I still see a lot of theia stuff in the repo 1359 results - 218 files when searching for theia in the whole repo, also there's this issue open #4630, should we close it or is this still WIP? should we schedule the complete removal of theia in the whole repo? cc @akosyakov

@iQQBot
Copy link
Contributor

iQQBot commented Jan 5, 2022

This PR just removes build-related stuff to avoid wasting resources

@akosyakov
Copy link
Member

It would be good to clean up old code for sure, but not everything is trviai to remove. If we can have split it and remove bit by bit when someone have spare time it would be good. Otherwise focusing on user valuable issues is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants