Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Do not start binaries in verbose mode #7774

Merged
merged 1 commit into from Jan 25, 2022
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 22, 2022

Related Issue(s)

Fixes #7773

How to test

Release Notes

[installer] Do not start binaries in verbose mode

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/S labels Jan 22, 2022
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #7774 (18a2c54) into main (e335309) will increase coverage by 4.45%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7774      +/-   ##
==========================================
+ Coverage   10.38%   14.83%   +4.45%     
==========================================
  Files          18       44      +26     
  Lines         992     4341    +3349     
==========================================
+ Hits          103      644     +541     
- Misses        888     3634    +2746     
- Partials        1       63      +62     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <0.00%> (-0.18%) ⬇️
components-ws-daemon-app 21.84% <0.00%> (?)
components-ws-daemon-lib 21.84% <0.00%> (?)
installer-raw-app 5.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/credential-helper.go 1.20% <0.00%> (-0.14%) ⬇️
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.61% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 30.05% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/tlssecret.go 0.00% <ø> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.95% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5d13a...18a2c54. Read the comment docs.

@aledbf aledbf force-pushed the aledbf/verbose branch 2 times, most recently from 1e1b94e to 3c5dc60 Compare January 25, 2022 10:35
@mrsimonemms
Copy link
Contributor

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbaa3ed34a34a67c80520c78b7a960c6b10c43b7

@aledbf
Copy link
Member Author

aledbf commented Jan 25, 2022

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, MrSimonEmms

Associated issue: #7773

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 7640c60 into main Jan 25, 2022
@roboquat roboquat deleted the aledbf/verbose branch January 25, 2022 15:53
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer] The rendered manifests set the flag -v for all the components
3 participants