Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Start XL workspaces with internal-xl class #9705

Merged
merged 2 commits into from
May 31, 2022

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented May 2, 2022

Description

This change starts workspaces which should get more resources using the gitpodio-internal-xl class.
Note: we have to deploy workspace clusters which support this class first.

Release Notes

NONE

@aledbf
Copy link
Member

aledbf commented May 10, 2022

@csweichel if we introduce the label validation, then we don't need #9868
(only to change the default class to "default" - or something)

@stale
Copy link

stale bot commented May 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added meta: stale This issue/PR is stale and will be closed soon and removed meta: stale This issue/PR is stale and will be closed soon labels May 25, 2022
@aledbf
Copy link
Member

aledbf commented May 30, 2022

@csweichel I added a commit to set the default workspace class name to default

@aledbf aledbf self-requested a review May 30, 2022 20:49
@aledbf
Copy link
Member

aledbf commented May 30, 2022

/hold

@aledbf aledbf marked this pull request as ready for review May 30, 2022 20:50
@aledbf aledbf requested a review from a team May 30, 2022 20:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 30, 2022
@aledbf
Copy link
Member

aledbf commented May 30, 2022

@csweichel @geropl this is the same PR as #10351 deployed today in the two meta clusters.

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexTugarev
Copy link
Member

AlexTugarev commented May 31, 2022

/werft run

👍 started the job as gitpod-build-cw-internal-xl-class.7
(with .werft/ from main)

@jankeromnes
Copy link
Contributor

This needs a rebase, right?

[Validating configuration] STDERR: Error: error loading config: error unmarshaling JSON: while decoding JSON: json: unknown field "usage"

@csweichel
Copy link
Contributor Author

/hold cancel

@roboquat roboquat merged commit 23c7726 into main May 31, 2022
@roboquat roboquat deleted the cw/internal-xl-class branch May 31, 2022 07:49
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants