Github's Authorize Button Disabled in Android WebView #674

pallavbakshi · 2017-12-20T17:14:32Z

Question	Response
Version?	v1.4.1
Devices tested?	Xiaomi Mi 4 - Android 5.0

What Currently Happens?

Upon logging in, the inbuilt browser showcases a Github auth page with the green button (Authorize) disabled.

This problem is encountered only when the sign-in flow is interrupted due to some user circumstances. For example, if you download the app for the first time and click sign-in, it will take you to the Github Auth page where you can enter your details to allow git-point to access your profile/repo. Once you successfully sign in, Github asks you to allow the app the required permissions. At this point, the green button is working (if this is a fresh sign-in attempt) and the cancel button is disabled so the user cannot break the flow. However, due to external circumstances, like a phone call or if the user closes the app or anything else, the sign-in process in broken in between. User has already signed in to the Github web page but hasn't authorized the GitPoint app yet. Now when the user reopens the app and tries to sign in, he is directly taken to the authorization page (permission page where he left last time). He is asked to allow the app to access its profile, etc. And at this time the green button (authorize button) is disabled. It shall be noted that scrolling and normal tapping is still enabled. ONLY the authorize button is disabled.

What Do You Expect To Happen?

Green button to be enabled.

My Reproduction Steps

Mentioned above.

Try sign-in for the first time
Enter credentials. Don't approve the app though.
Close the app (don't authorize the app yet)
Reopen the app and try to sign-in

My personal view of what is happening -
Since the android WebView saves the cache/cookies therefore the app picks up from the last point where the user left the signin process on the github page (that is why user doesn't need to sign in). However, the javascript seems to be disabled which disables the green button. I have only checked it in Android.

machour · 2018-01-16T10:00:00Z

I think this is the same as #680 and is addressed by #681
Leaving this open for the wonderful details, thank you @pallavbakshi !

pallavbakshi · 2018-01-16T10:50:04Z

Ha ha! I came first though (Mine issue is 674). Fun aside, I will test it and close the issue if it is fixed. However, it will take me some time to test it. Thanks :D

machour · 2018-01-16T10:54:30Z

hahahaha, you just reminded me when I told my grandpa older brother: "oh you look like grandpa" and he shouted at me "no, HE looks like ME" 🤣

I think @housseindjirdeh will be providing a test APK shortly for #680, I'll make sure to notify you so that you can test as well. Thank you soo much!

housseindjirdeh · 2018-01-18T15:11:32Z

@pallavbakshi here's the APK with the fix: https://github.com/gitpoint/git-point/releases/tag/hotfix

Please take as long as you need to give it a shot, there's definitely no rush :)

pallavbakshi · 2018-01-18T15:25:02Z

@housseindjirdeh Thanks! I will check it soon, hopefully.

ShalokShalom · 2018-02-13T09:26:17Z

This is still the case for me, while I use the default browser in BlackBerry OS 10.

machour · 2018-02-13T09:34:13Z

Thank you for the feedback. We need to get rid of that WebView and use something like react-native-oauth..

ShalokShalom · 2018-02-13T13:10:01Z

Thanks a lot :D

I can open another issue, for the integration of react-native-oauth or the evaluation of alternatives?

What is most easy to integrate?

Fast Hub uses Tokens too:
https://github.com/k0shk0sh/FastHub#features

machour · 2018-02-13T13:52:13Z

Please do! If you want to give it a shot, we'll gladly accept a PR too 😅

ShalokShalom · 2018-02-18T19:25:49Z

Ok, same news: Its in the auth app itself.

This issue happens to me on all different implementations.
And the auth on pages who offer both, Twitter and Github works for Twitter and not for Github.

machour · 2018-03-22T15:47:27Z

@pallavbakshi could you remove the app and install https://idk.tn/gitpoint-test.apk ?

After clicking "Sign in" you should see a really ugly "Can't sign in?" button that will open the GitHub oAuth URL in your browser. Tell me if that works for you 🙏

pallavbakshi · 2018-03-23T01:43:19Z

Hey hey!! @machour ... Sure I'll do so over this weekend. Thanks for your patience and hard work.

Mouvedia · 2018-03-26T23:08:10Z

It's immediately disabled on iOS 9: it's unusable.

machour · 2018-03-26T23:09:46Z

Hi @Mouvedia, this issue happens only on Android to my knowledge. Can you provide us with some more information about your device?

Mouvedia · 2018-03-26T23:13:50Z

@machour iOS 9.3.5 iPhone 4S

machour · 2018-03-27T00:40:43Z

@Mouvedia If the button is not clickable, it means that GitHub doesn't support your browser (we're using a WebView). But this seems odd.

Are you able to click the button on this link using Safari (Private Navigation): https://github.com/login/oauth/authorize?response_type=token&client_id=87c7f05700c052937cfb&redirect_uri=gitpoint://welcome&scope=user%20repo&state=foobar

Mouvedia · 2018-03-27T00:46:03Z

@machour I cannot on my iPhone.

machour · 2018-03-27T00:46:27Z

Can you provide a screenshot?

Mouvedia · 2018-03-27T00:48:24Z

If you don't believe me that's fine by me.

machour · 2018-03-27T00:55:23Z

Wow wow wow, you totally misunderstood my request pal :)

I asked if you were able to click the button directly in Safari, because Safari is used in our application in a webview, and I wanted to verify if our integration was faulty or not.

You said that you were unable to.

I asked for a screenshot of the page on Safari to see if I could spot any error that would help me understand the problem, and not in any way because I didn't believe you. Now can I have this screenshot or not ? :)

By the way, the URL I provided is using our dev client_id and may brake at any time.

Mouvedia · 2018-03-27T01:05:39Z

There's nothing to see, just a disabled button. It's probably the same problem: you gotta enable javascript explicitly.

machour · 2018-03-27T01:06:54Z

Should be enabled in Safari..

Mouvedia · 2018-03-27T01:08:07Z

Please note that GitHub no longer supports old versions of Safari.

Indeed. Well in the meantime could you share the prod url as a workaround ?

machour · 2018-03-27T01:16:03Z

I don't understand how you're gonna use it as you're reporting it doesn't work in Safari, but there you go: https://github.com/login/oauth/authorize?response_type=token&client_id=5f4e87fae2ea9d3d27c4&redirect_uri=gitpoint://welcome&scope=user%20repo&state=foobar

Mouvedia · 2018-03-27T01:22:07Z

Well actually I managed to do it, here's the workaround:

authorize yourself using the link in this comment
click on this link this time from within safari on your iPhone and get redirected to the installed app
end up on a frozen welcome page
close the app
reopen

machour · 2018-03-31T14:43:05Z

@pallavbakshi sorry to bug you, but could you possibly confirm that https://idk.tn/gitpoint-test.apk works for you?

I'd love to ship the fix in a release soon 😄

pallavbakshi · 2018-04-03T01:46:40Z

Fixed.

machour · 2018-04-03T09:46:37Z

Thank you so much @pallavbakshi 🎉 🎉

SenzoNgele · 2020-11-25T08:49:16Z

Lool after I struggled for years.. I have found a Solution to This
The course is. First I use my google chrome which I saved my Github account with.
So my VS was taking me to Microsoft Edge and get the button disabled.

All you have to do is to change you Default browser on your machine to the one u have signed is with on github

andrewda added android 🐛 bug labels Dec 20, 2017

machour added the has pr label Jan 16, 2018

housseindjirdeh mentioned this issue Jan 31, 2018

Stuck on authorization screen #680

Closed

ShalokShalom mentioned this issue Feb 13, 2018

Github Auth Button disabled slapperwan/gh4a#818

Open

ShalokShalom mentioned this issue Feb 15, 2018

new auth methods #732

Closed

machour added this to Todo in 1.6.0 Feb 16, 2018

ShalokShalom mentioned this issue Mar 19, 2018

Authorization failed #740

Closed

chinesedfan moved this from Todo to In Progress in 1.6.0 Mar 23, 2018

machour mentioned this issue Mar 24, 2018

fix(login): Provide an escape hatch for Android #749

Merged

machour closed this as completed Apr 3, 2018

machour moved this from In Progress to Done in 1.6.0 Apr 3, 2018

tylerperkins mentioned this issue Aug 4, 2018

Cannot login github account CodeHubApp/CodeHub#471

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Github's Authorize Button Disabled in Android WebView #674

Github's Authorize Button Disabled in Android WebView #674

pallavbakshi commented Dec 20, 2017 •

edited

machour commented Jan 16, 2018 •

edited

pallavbakshi commented Jan 16, 2018

machour commented Jan 16, 2018

housseindjirdeh commented Jan 18, 2018

pallavbakshi commented Jan 18, 2018

ShalokShalom commented Feb 13, 2018

machour commented Feb 13, 2018

ShalokShalom commented Feb 13, 2018

machour commented Feb 13, 2018

ShalokShalom commented Feb 18, 2018

machour commented Mar 22, 2018

pallavbakshi commented Mar 23, 2018

Mouvedia commented Mar 26, 2018 •

edited

machour commented Mar 26, 2018

Mouvedia commented Mar 26, 2018

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 •

edited

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 •

edited

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 •

edited

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 •

edited

machour commented Mar 31, 2018

pallavbakshi commented Apr 3, 2018

machour commented Apr 3, 2018

SenzoNgele commented Nov 25, 2020

Github's Authorize Button Disabled in Android WebView #674

Github's Authorize Button Disabled in Android WebView #674

Comments

pallavbakshi commented Dec 20, 2017 • edited

What Currently Happens?

What Do You Expect To Happen?

My Reproduction Steps

machour commented Jan 16, 2018 • edited

pallavbakshi commented Jan 16, 2018

machour commented Jan 16, 2018

housseindjirdeh commented Jan 18, 2018

pallavbakshi commented Jan 18, 2018

ShalokShalom commented Feb 13, 2018

machour commented Feb 13, 2018

ShalokShalom commented Feb 13, 2018

machour commented Feb 13, 2018

ShalokShalom commented Feb 18, 2018

machour commented Mar 22, 2018

pallavbakshi commented Mar 23, 2018

Mouvedia commented Mar 26, 2018 • edited

machour commented Mar 26, 2018

Mouvedia commented Mar 26, 2018

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 • edited

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 • edited

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 • edited

machour commented Mar 27, 2018

Mouvedia commented Mar 27, 2018 • edited

machour commented Mar 31, 2018

pallavbakshi commented Apr 3, 2018

machour commented Apr 3, 2018

SenzoNgele commented Nov 25, 2020

pallavbakshi commented Dec 20, 2017 •

edited

machour commented Jan 16, 2018 •

edited

Mouvedia commented Mar 26, 2018 •

edited

Mouvedia commented Mar 27, 2018 •

edited

Mouvedia commented Mar 27, 2018 •

edited

Mouvedia commented Mar 27, 2018 •

edited

Mouvedia commented Mar 27, 2018 •

edited