Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Bar text color on Repository and User Profile Screen #176

Closed
darecki opened this issue Jul 27, 2017 · 3 comments
Closed

Status Bar text color on Repository and User Profile Screen #176

darecki opened this issue Jul 27, 2017 · 3 comments

Comments

@darecki
Copy link

darecki commented Jul 27, 2017

Status Bar text is black on a dark gray background. It's completely unreadable. We should either make it white or hide it completely if it's not relevant. The same issue is visible on the user profile page.
repository

darecki pushed a commit to darecki/git-point that referenced this issue Jul 27, 2017
@darecki
Copy link
Author

darecki commented Jul 27, 2017

Unfortunately I found out that my implementation changes the status bar color for all the screens. The question is why is it happening that way?

@andrewda
Copy link
Member

I think there was some discussion around this in #4.

@housseindjirdeh
Copy link
Member

Thanks a million for logging this @darecki and getting some code up for it so fast :)

So I opened a similar issue for this exact thing #4 and the behaviour is weird unfortunately. Although adding the prop toViewContainer should only change it for the current screen since it ties into the StatusBar API - it's how we defined navigation in the app that's causing this. The app works with a TabNavigator routing logic where each tab is a separate stack of screens. AuthProfile happens to be the first screen in the last stack of the tab (see here and here). For some unusual reason - changing the status bar for the first screen in the stack changes it for all screens which is unfortunate.

@ShaunLloyd spent a little bit of time looking at this and there's discussion over at #4 so I'll close this duplicated issue. Happy to discuss the approach to your PR there and figure out how we can best solve this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants