New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localization): various localization improvements #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I did dynamic output of languages (from file Also I suggest to show native names of languages, instead of in English, i.e. Deutsch instead of German, for example, how do you like this proposal? |
77ce171
to
b779b25
Compare
…to localization-fixes
src/auth/screens/events.screen.js
Outdated
y: '%dy', | ||
yy: '%dy', | ||
}, | ||
const language = I18n.locale.substr(0, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done so for the time being, but this is essentially the initialization of the moment
, and it should not be executed here (where can it be moved?), it first. And secondly, only the device language is taken into account here, but if the language was changed in the settings, then the date/time language (ie moment
) will remain unchanged (we must also take into account the language in the storage). What can we do about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I solved this problem, you can see in this commit. Now the configuration of the locale is made in App.js
, as it probably should be there and localization works as I described it in my comment.
In my opinion, it turned out pretty good, as usual, I'm waiting for your feedback 🙌
Also, look at this commit, I did support the localization of events better, it looks like it worked out well, but I want to know your opinion 😌 |
@lex111 you said:
Two "solutions":
|
@Antoine38660 thanks, but unfortunately did not work |
@Antoine38660 hurraaay, I did it, I misunderstood how to use |
Awesome dude! 🎉 🎉 🎉 11/11 checks. I'll look at your code tonight 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
07fa7fe
to
bc73e88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such an amazing PR 😍 😍 😍
I can't see anything that needs changing from the onset. Thank you so much @lex111 we really owe you one <3
Woops I'm sorry if I merged it too prematurely in case you wanted to take a look as well @Antoine38660. Please let us know if you see anything that should be changed and we can address it in a future PR |
searchType
to localizationupdateText
when change language + minor fixes{{payload}}
(action
andref_type
,) to localization file for events screen (eg, "created", "edited", "moved" or "deleted", "commented", etc). See details here. (Important)moment
(done, but needs review!)Possible solution: export all available languages (locale/languages/index.js). A new key is added:
originalName
(or simplytitle
) - this is the national name of the language (it will be displayed). Or something like this (information about the language at the beginning of each language file):Members
andDescription
on organization screenStars
,Forks
,forked from
,View All
(PR list) on repository screenOpen
,Close
on PR screenPost
(comment input component)Do not hesitate to update this PR, if you want!