fix(profile): navigate to AuthProfile for current user #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the current user could find and follow himself from the search screen. Need to navigate the current user to auth profile screen. Closes: gitpoint#247
lex111
reviewed
Aug 16, 2017
| > | ||
| <ImageContainerComponent | ||
| style={styles.avatarContainer} | ||
| const CorrectScreen = |
There was a problem hiding this comment.
Variable names are written in lowerCamelCase. And it's better to call the variable userScreen.
There was a problem hiding this comment.
Ah, my bad. I'll fix it
lex111
requested changes
Aug 16, 2017
| onPress={() => | ||
| navigation.navigate('Profile', { | ||
| navigation.navigate(CorrectScreen ? 'AuthProfile' : 'Profile', { |
There was a problem hiding this comment.
You can just left CorrectScreen, because we store the name of the screen, then you do not need a ternary operator.
| <ImageContainerComponent | ||
| style={styles.avatarContainer} | ||
| onPress={() => | ||
| navigation.navigate(CorrectScreen ? 'AuthProfile' : 'Profile', { |
lex111
approved these changes
Aug 16, 2017
andrewda
changed the title
housseindjirdeh
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
UserListItemcomponent statefulstate.auth.userAuthProfileScreen