feat(translation): add brazilian portuguese translations #284
Conversation
src/locale/languages/br.js
Outdated
| yy: '%dy', | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
I'm not a language expert by any means. How different are Portuguese and Brazilian Portuguese? If they're very similar (UK English vs. US English), I think it probably makes more sense just to use "Portuguese".
There was a problem hiding this comment.
In my opinion, Portugal and Brazilian Portuguese are not very similar like UK and US English, altough they share a lot of aspects, but vocabulary, phonetics and syntax are differ a bit. But yeah, maybe we could use the same translation.
There was a problem hiding this comment.
Alright, if they're not too similar then this is totally fine!
| @@ -15,4 +15,8 @@ export default [ | |||
| code: 'tr', | |||
| name: 'Türkçe', | |||
| }, | |||
| { | |||
| code: 'br', | |||
There was a problem hiding this comment.
Because this is not pure Brazilian, the code should be such pt-br, this also applies to the file name.
There was a problem hiding this comment.
I was going to use pt-br, but the instructions says that we should use a two-letter code from here, so I used only br. Should I change?
There was a problem hiding this comment.
Yea, those instructions should probably be changed. In this case, pt-br makes perfect sense.
There was a problem hiding this comment.
Okay, I will change the code and the file name as soon as I can. Thank you both for the suggestions and corrections.
There was a problem hiding this comment.
All in all, this looks great. Thanks for spending the time to do this @arthurdenner, can't tell you how much we appreciate it :)
Thanks a million @lex111 and @Antoine38660 for taking a look at this 🙌 Please feel free to do a second pass through whenever you get the chance and if all looks good, we can merge this baby in.
@arthurdenner don't forget to add yourself as a contributor with yarn contributors:add! Feel free to do it as part of this PR or a separate one :)
| @@ -206,7 +206,9 @@ export const RepositoryProfile = ({ | |||
| ? abbreviateNumber(repository.watchers_count) | |||
| : ' '} | |||
| </Text> | |||
| <Text style={styles.unitText}>Watchers</Text> | |||
There was a problem hiding this comment.
Thanks so much for noticing some stray translations <3
| @@ -9,3 +9,5 @@ export const emojifyText = text => { | |||
| export const abbreviateNumber = count => { | |||
| return count >= 1000 ? (count / 1000).toFixed(1) + thousandUnit : count; | |||
| }; | |||
|
|
|||
| export const oneLineText = text => text.replace(/\s\s+/g, ' '); | |||
| @@ -15,4 +15,8 @@ export default [ | |||
| code: 'tr', | |||
| name: 'Türkçe', | |||
| }, | |||
| { | |||
| code: 'ptBr', | |||
There was a problem hiding this comment.
The code must be written with a hyphen (pr-br); It will then be used in the library moment, and there it is necessary to write the language through a hyphen.
|
@housseindjirdeh I just committed updating the branch with the last master commit, changing what lex requested and, following your request, adding myself as contributor (to spare another PR). I guess everything is okay now? If not, let me know, please. |
|
Looks all good except for the small merge conflicts. I can try to resolve. |
andrewda
changed the title
Hi, guys.
Sorry for the wait to make this PR, I was very busy during the week.
I want to point that my last commit was a fix to the changes made in the turkish file after committing (idk what happened tbh, sorry about any mess that this may cause).
While translating, I created a function to make "one line texts" (I don't like to scroll horizontally xD). Hope that's OK. Also, during testing, I found three texts without translation available through files, so I changed them. Hope that's OK also.
Last but not least, sorry about the unformatted commits, I totally forgot about git cz (in 12 minutes, because my first commit was using it, smh).