fix(profile): fix the wrong follows you badge

[chinesedfan]

Closed #308

[andrewda]

👌

[machour]

This partially fixes the problem. Now, a user following me isn't shown as so :/

For example, the user tunecino is one of my followers, but its profile only shows that I'm following him.

[machour]

Guys, after some analysis, here's what I've found:

• When on a user profile page, the user parameter passed to getFollowers is a string, not an object, so user.login is undefined in this context and user should be used instead: https://github.com/gitpoint/git-point/blob/master/src/user/user.action.js#L96
• In here, auth is an object, so we should test against auth.login instead: https://github.com/gitpoint/git-point/blob/master/src/user/screens/profile.screen.js#L124
• I think there's an original logic flaw, as isFollower is supposed to tells if a user X is following me, yet, the function takes the user X followers and compares them against my login, which makes no sense at all.

We should either take the list of users X is following and compare them towards the authenticated user, or maybe use another lighter API call:

GH Api allows the following call:
https://api.github.com/users/tunecino/following/machour

If tunecino is following machour, the request will just respond with a 204 status code and no contents.
If tunecino is not following machour, the request will respond with a 404 status code

🍺  ~/gitpoint-clean (master)*$ wget https://api.github.com/users/tunecino/following/machour
--2017-09-08 14:50:05--  https://api.github.com/users/tunecino/following/machour
Resolving api.github.com... 192.30.253.117, 192.30.253.116
Connecting to api.github.com|192.30.253.117|:443... connected.
HTTP request sent, awaiting response... **204 No Content**
2017-09-08 14:50:07 (0.00 B/s) - ‘machour’ saved [0]

🍺  ~/gitpoint-clean (master)*$ wget https://api.github.com/users/tunecino/following/chinesedfan
--2017-09-08 14:50:13--  https://api.github.com/users/tunecino/following/chinesedfan
Resolving api.github.com... 192.30.253.117, 192.30.253.116
Connecting to api.github.com|192.30.253.117|:443... connected.
HTTP request sent, awaiting response... **404 Not Found**
2017-09-08 14:50:14 ERROR 404: Not Found.

Could you please review my assertions? My brain may have been scrambled by following/followers/isFollowing :) (maybe we do need to rename variables to something like isFollowingMe, .. )

[chinesedfan]

@machour I agree with you.

The current method is not 100% right even if we fixed those bugs. Because obtained followers are just the first page, whose size is 100. I will try the specified API to check whether A is following B.

[chinesedfan]

@machour Hope I really solved the problem this time. Renaming variables needs to modify too many codes, so I give up. But I add 2 comments in src/user/user.reducer.js to clarify differences of them: https://github.com/chinesedfan/git-point/blob/issue308/src/user/user.reducer.js#L18.

@lex111 @andrewda Please review again.

[machour]

Nice work @chinesedfan, everything looks fine with my tests 👌

[housseindjirdeh]

Maan I can't thank you folks enough. Thank you @chinesedfan for diving into this and thank you @machour for spotting this bug and testing this and thank you @lex111 and @andrewda for reviewing this 🙌

Looks solid all around in my opinion!