Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(screen): add support for landscape orientation #333

Merged
merged 3 commits into from
Sep 17, 2017

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Sep 15, 2017

I do not know, maybe it was so necessary, but I added support for landscape orientation. In this regard, we had to slightly change the parallax component , but everything seems to be fine.

screenshot_1505503493

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome thanks a million for this 😍. It was specifically this screen that was rendering funky on landscape hence why I locked it to portrait. This will make a huuge difference on tablets as well 🙌

All the other screens seem to be okay right? Alsoo, how does your home events tab show 11 events? 👀

@housseindjirdeh housseindjirdeh merged commit a21e920 into gitpoint:master Sep 17, 2017
@lex111
Copy link
Member Author

lex111 commented Sep 17, 2017

@housseindjirdeh oh, oops, this is my experiment. I thought, to output the number of unread notifications in such a way that you think about it? Do the icons for notifications do this.

@housseindjirdeh
Copy link
Member

I think that's an amazing idea :) One thing that would also be nice is potentially show the unread notifications in a slightly different way (maybe with a gray background for example) when the user navigates to that tab. But I think that's great :D

However will definitely like to get other people's opinions on this as well. Will open an issue later to discuss 🎉

@lex111 lex111 deleted the landscape-orientation branch September 17, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants