feat(android): Implement round and adaptive icon #340
Conversation
android/app/build.gradle
Outdated
| compileSdkVersion 23 | ||
| buildToolsVersion "23.0.1" | ||
| compileSdkVersion 26 | ||
| buildToolsVersion '25.0.3' |
There was a problem hiding this comment.
Can the same up to 26 versions raise? I do not know for sure, just wondering.
|
Here's what the progressive icon looks like among other icons in Android O:
@housseindjirdeh do we give it more margin to make it look like the rounded icon on https://gitpoint.co/? or do we do the opposite? 🤔 |
android/app/build.gradle
Outdated
| compileSdkVersion 23 | ||
| buildToolsVersion "23.0.1" | ||
| compileSdkVersion 26 | ||
| buildToolsVersion '26.0.1' |
There was a problem hiding this comment.
I'll be pedantic, but let's change the quotes to double, as it used to be? 😄
There was a problem hiding this comment.
** curses Android Studio **
There was a problem hiding this comment.
Looks so great 😍
I think it works the way you have it, most of the adaptive icons seem to have a little margin (not nearly as much as https://gitpoint.co) so I think this fits. We can definitely reduce the margins on the site logo a bit to match if you like.
In this PR:
roundIconfor devices supporting it since 7.1mipmap-anydpi-v26Since we're using
roundIconnow, I was forced to duplicate the Android-O icon XML file,or else Android O kept using the PNGs provided in roundIcon.
Fixes #297 and #275