Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-colors): fix/add language colors #352

Merged
merged 1 commit into from Sep 23, 2017

Conversation

0xch4z
Copy link
Contributor

@0xch4z 0xch4z commented Sep 23, 2017

Fixes C++ color and adds some missing languages.

@lex111
Copy link
Member

lex111 commented Sep 23, 2017

@Charliekenney23 hello and welcome! Why so many files in PR? I mean, there should be like two files: .all-contributorsrc and src/config/colors.js. Can we remove the others?

@0xch4z
Copy link
Contributor Author

0xch4z commented Sep 23, 2017

Yikes, just realized that. I guess they were mysteriously added in the build step. Let me reset head and recommit only those files.

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @Charliekenney23, and welcome 🎉 🎉

Just seconding @lex111 note. All of the extra files most likely just showing because of master being linked separately with your branch. As soon as you only have the two files staged (.all-contributorsrc and colors.js), will merge this baby in

@0xch4z
Copy link
Contributor Author

0xch4z commented Sep 23, 2017

All set. Thanks for the warm welcome! I'm really enjoying the app. Hope to contribute some more code soon!

@housseindjirdeh
Copy link
Member

So glad you like the app mate, don't hesitate to contribute some more anytime and we're more than happy to help you understand how any part of the codebase works!

@housseindjirdeh housseindjirdeh merged commit bf0cb41 into gitpoint:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants