Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): add pull to refresh if notifications is empty #365

Merged
merged 1 commit into from Sep 28, 2017

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Sep 26, 2017

This may not be entirely customary, if we do not have elements, then pull-to-refresh should not be, but in my opinion this will be a nice addition.

Also, I even aligned the message "receiving notifications" in the center, so it seems to me better. Although it was required to determine the height (saveContentBlockHeight) and to set the height for the blocks to align, there may be a way to do without it, but I did not find.

Demo:

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great touch, I think it looks so much better in the center and I can't see why we shouldn't be able to pull to refresh when there's no items!

Thanks a million matey, it looks solid 🎉

@housseindjirdeh housseindjirdeh merged commit 2674716 into master Sep 28, 2017
@lex111 lex111 deleted the pull-to-refresh-empty-notifications branch September 28, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants