fix(markdown): fix various markdown issues #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
reviewed
Sep 26, 2017
| class CellWithImage extends Cell { | ||
| render() { | ||
| const { data, width, height, flex, style } = this.props; | ||
| let borderWidth; |
There was a problem hiding this comment.
Do you think, if you set the variables (borderWidth, borderColor) to default values, and thus remove the else branch?
lex111
reviewed
Sep 26, 2017
| @@ -266,19 +306,33 @@ export class MarkdownHtmlView extends Component { | |||
| styleText.textAlign = cellAlign[attribs.style]; | |||
| } | |||
|
|
|||
| const Component = | |||
| node.children.filter( | |||
| elem => elem.type === 'tag' && elem.name === 'img' | |||
There was a problem hiding this comment.
Do you think it would be possible to move this arrow function in a separate function, if it is used more than once?
lex111
approved these changes
Sep 27, 2017
andrewda
approved these changes
Sep 27, 2017
housseindjirdeh
approved these changes
Sep 28, 2017
There was a problem hiding this comment.
Beautiful, thank you so so much @machour. You single-handedly made comments look beautiful in the app 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #363
The problems were :
<th>was HTML escaped: it needed to be displayed usingdefaultRenderer<img>inside a<td>caused a crash (View in Text): We created our own Cell component that avoids using<Text>piece of codeas a<pre>if inside a<li>: Setting it to be pedantic helpedI also made images inside cells take 30% of the screen width while enlarging a bit images outside cells.