Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): Run getRepositoryFile() through API, not raw.githubcontents #392

Merged
merged 1 commit into from Sep 30, 2017
Merged

fix(api): Run getRepositoryFile() through API, not raw.githubcontents #392

merged 1 commit into from Sep 30, 2017

Conversation

machour
Copy link
Member

@machour machour commented Sep 30, 2017

Since the API change from #361, file source code fetching have not been working.

The problem was calling .download_url which points to a raw file on raw.githubcontents.com instead of .url which holds a proper API url.

housseindjirdeh
housseindjirdeh approved these changes Sep 30, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful thank you <3

@housseindjirdeh housseindjirdeh merged commit ad7ec47 into gitpoint:master Sep 30, 2017
@machour machour deleted the fix-code-file-display branch September 30, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 approved these changes

@andrewda andrewda andrewda approved these changes

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
🐛 bug high priority ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machour @lex111 @andrewda @housseindjirdeh