fix(dependencies): make react-native-app-intro work with React 16 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add prop-types to react-native-app-intro. Faster means of fixing bug than finding an alternative and changing cod #395
Add username to contributors
andrewda
requested changes
Oct 1, 2017
package.json
Outdated
| @@ -57,7 +57,7 @@ | |||
| "react": "16.0.0-alpha.12", | |||
| "react-native": "0.48.1", | |||
| "react-native-actionsheet": "^2.2.0", | |||
| "react-native-app-intro": "^1.1.5", | |||
| "react-native-app-intro": "https://github.com/Ernoff/react-native-app-intro.git#updated-packageJson", | |||
There was a problem hiding this comment.
👏 Though it would be sweet if you could publish on NPM if at all possible so we don't have too many GitHub repos in the package.json.
There was a problem hiding this comment.
Okay Great!!
I will get down to it
andrewda
changed the title
replace react-native-app-intro with rn-app-intro to cater for React v16.^ #399
housseindjirdeh
pushed a commit
that referenced
this pull request
Oct 1, 2017
…400) * fix(dependencies): Fix dependency issue of react-native-app-intro Add prop-types to react-native-app-intro. Faster means of fixing bug than finding an alternative and changing cod #395 * docs(contributors): Add username Add username to contributors * fix(dependencies): package fix into a node package replace react-native-app-intro with rn-app-intro to cater for React v16.^ #399 * docs: update contributors
housseindjirdeh
pushed a commit
that referenced
this pull request
Oct 2, 2017
* fix(dependencies): Fix dependency issue of react-native-app-intro Add prop-types to react-native-app-intro. Faster means of fixing bug than finding an alternative and changing cod #395 * docs(contributors): Add username Add username to contributors * fix(dependencies): package fix into a node package replace react-native-app-intro with rn-app-intro to cater for React v16.^ #399 * docs: update contributors * chore(login screen): remove unnecessary braces remove unneccesary braces that arose from my keyboard malfunctioning * chore(login screen): remove trailing braces remove trailing and irrelevant braces within login screen * chore(brace clean up): one more brace to delete 410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of finding alternative and changing the respective code, I just went along to help fix react-native-app-intro by including prop-types as needed thereby making it compatible with React 16.^
Kindly review and send feedback where needed.
#395