fix: various minor updates #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
force-pushed
the
minor-updates
branch
from
8c26c4d
to
40d3f70
Compare
lex111
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been going through the app on my device for the past hour. We've all done so much to improve it it's crazy :D
Noticed a few things:
Definitely thought we can bump it up a bit. Noticed that we were conditionally making it smaller and lighter for iOS. Fixed it and looks better with the changes in this PR I think:
Did the same for a few other screens as well:
Also added a Donate link in the options screen. Relatively straightforward translation string so used Google Translate :)
And finally, moved the contributors to
CONTRIBUTING.mdbecause it really was filling upREADMEgiven our open collective inclusions. Happy to take a PR to move this to a separate file (CONTRIBUTORS.md) if everyone would prefer that like we mentioned previously.