Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications badge count has styling issues #581

Closed
chinesedfan opened this issue Oct 25, 2017 · 3 comments
Closed

Notifications badge count has styling issues #581

chinesedfan opened this issue Oct 25, 2017 · 3 comments
Labels
hacktoberfest has pr styling
Projects
v1.4.0

Comments

@chinesedfan
Copy link
Member

Separated from #569.

image
@chinesedfan chinesedfan added this to To Do in v1.4.0 Oct 25, 2017
@LinnJS
Copy link

LinnJS commented Oct 26, 2017

So you want it to be a complete circle? I will take this issue just need to know exactly what you want it to look like.

@t-howell t-howell mentioned this issue Oct 26, 2017
Closed
@alejandronanez
Copy link
Member

@JSLinn727 yeah it should be a full circle with the number in the middle.
Thanks for your interest!

@machour machour moved this from To Do to In Progress in v1.4.0 Nov 5, 2017
@machour machour added has pr and removed help wanted labels Nov 5, 2017
@machour machour mentioned this issue Nov 25, 2017
Merged
@machour machour moved this from In Progress to Ready for review in v1.4.0 Nov 25, 2017
@chinesedfan
Copy link
Member Author

Fixed by #648.

@chinesedfan chinesedfan moved this from Ready for review to Completed in v1.4.0 Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest has pr styling
Projects
No open projects
v1.4.0
Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@machour @alejandronanez @chinesedfan @LinnJS