Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove containers styles that confuses the button #656

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

machour
Copy link
Member

@machour machour commented Dec 9, 2017

Question . Response
Version? master .
Devices tested? iPhone 7, Nexus 5
Bug fix? yes
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #624

Screenshots

Before After
screen shot 2017-12-09 at 11 27 57 am  screen shot 2017-12-09 at 11 26 35 am

Description

Removed two (unneeded) styles from the container, that seems to be confusing the button layout.
Wasn't able to reproduce the problem anymore with this patch applied.

This is the iOS fix for #624, tested on both iOS and Android (no regressions)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.861% when pulling afd65b3 on machour:fix-merge-button into 14532ce on gitpoint:master.

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 <3

@housseindjirdeh housseindjirdeh merged commit ebfb02c into gitpoint:master Dec 10, 2017
@machour machour deleted the fix-merge-button branch December 10, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants