-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Fix entity-info styling #586
Conversation
A bit random but @housseindjirdeh could you configure Coveralls to pass the Status Check as long as there's less than a 0.25% reduction in coverage? It's a bit silly to have it fail for this PR, or any PR that adds a tiny bit of complexity. |
Actually not sure how I feel about that... Maybe we should keep it as is so we can be aware of when we're lowering coverage. Input? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix on the problem, but yea it's interesting how this was fine w/o SC...
+1 on keep in it like that for now @andrewda |
Alright, this should be fine to be merged. I'm adding a lot more tests for EntityInfo, but will follow those up in a future PR. |
Finally had the time to investigate a bit more, there's an incompatibility between Styled-Components & React Native Elements where the default container style get lost. More info in this bug report: https://github.com/react-native-training/react-native-elements/issues/679 |
Closing this as #619 fixes the root cause |
Fixes unwanted UI changes introduced by #558
It seems that using styled-components the way it's done here does more harm than good. We didn't need to specify
font-weight 'normal'
, orwrapperStyle
in the past.It's like using styled-component completely reset the style of the react-native-elements component, and we have to specify defaults again. Really weird.
Another painful thing is that before using SC, the
hideChevron
prop produced consistent margins no matter of its value. With SC, I got this difference for the first element:I had to display the chevron, but transparent for that element, to produce a consistent margin.
The big question here: Is SC used as it should be here? Is this a bug of SC ?