Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): use jest mocks instead of sinon spies #591

Merged
merged 2 commits into from
Oct 27, 2017
Merged

refactor(tests): use jest mocks instead of sinon spies #591

merged 2 commits into from
Oct 27, 2017

Conversation

stupergenius
Copy link
Contributor

Per #588, removes the dependency on sinon and uses jest builtin mocks.

@stupergenius
build(yarn): Removed sinon dependency
ba09bac 
Removed sinon dependency using "yarn remove".
@stupergenius
test(tests): Refactored tests to use jest mocks
5d45088 
Refactored tests to use jest builtin mocks instead of sinon spies.

588
@andrewda andrewda changed the title Refactor to use jest mocks instead of sinon spies. refactor(tests): use jest mocks instead of sinon spies Oct 27, 2017
andrewda
andrewda approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@andrewda andrewda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewda
Copy link
Member

Will merge this as soon as tests pass 🎉

@coveralls
Copy link

Coverage Status

Coverage remained the same at 34.504% when pulling 5d45088 on stupergenius:refactor/use_jest_mocks into a9ae840 on gitpoint:master.

@andrewda andrewda merged commit 8e750a4 into gitpoint:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewda andrewda andrewda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stupergenius @andrewda @coveralls