Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commit): view commits #851

Merged
merged 5 commits into from Dec 1, 2018
Merged

feat(commit): view commits #851

merged 5 commits into from Dec 1, 2018

Conversation

chinesedfan
Copy link
Member

Question Response
Version? v1.6.0
Devices tested? iPhone 6 Simulator
Bug fix? no
New feature? yes
Includes tests? no
All Tests pass? yes
Related ticket? #5

Screenshots

Don't mind the merge button color. Because I can't find a mergable pull request again.

Before After
repo-old repo-new
pr-old pr-new

And two added screens.

List Detail
commit-list commit-detail

Description

Repicked @Antoine38660's work in #258. Migrated to the new i18n mechanism and did a little UI changes.

  • create new screens: commit and commit-list
    • make the committer name clickable
  • clickable branch name for push events in events screen
  • view commits from repository screen
  • show commits count and clickable in issue(pull request) screen

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 50.396% when pulling 7c1df1f on repick_258 into 54b5ff3 on master.

@chinesedfan
Copy link
Member Author

@gitpoint/maintainers To avoid blocking future changes, please forgive my dictatorship. I will merge this PR by myself without reviews.

@chinesedfan chinesedfan merged commit d1bb088 into master Dec 1, 2018
@chinesedfan chinesedfan deleted the repick_258 branch December 2, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants