Skip to content

Commit

Permalink
Don't preinstall dependencies in test_installation
Browse files Browse the repository at this point in the history
This removes the step in test_installation that did the equivalent
of "pip install -r requirements.txt", because installing GitPython
is sufficient to install all its required dependencies, and it is
more important to test that than to test requirements.txt directly.

Removing this causes the test to fail if installing the project
doesn't entail installation of the requirements necessary to import
the git module or to cause gitdb to be found in a sys.path search.
  • Loading branch information
EliahKagan committed Sep 10, 2023
1 parent b9b6d8c commit 21c5f87
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions test/test_installation.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,6 @@ def setUp_venv(self, rw_dir):
@with_rw_directory
def test_installation(self, rw_dir):
self.setUp_venv(rw_dir)
result = subprocess.run(
[self.pip, "install", "-r", "requirements.txt"],
stdout=subprocess.PIPE,
cwd=self.sources,
)
self.assertEqual(
0,
result.returncode,
msg=result.stderr or result.stdout or "Can't install requirements",
)
result = subprocess.run(
[self.pip, "install", "."],
stdout=subprocess.PIPE,
Expand Down

0 comments on commit 21c5f87

Please sign in to comment.