Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime.datetime type to commit_date and author_date #1501

Merged
merged 1 commit into from Oct 14, 2022

Conversation

SergeantMenacingGarlic
Copy link
Contributor

Update type hints to match acceptable date types.

Passing a datetime.datetime object for author_date or commit_date causes a mypy type error, these dates are passed to parse_date in git.objects.util, which does accept a datetime.datetime object.

@Byron Byron merged commit 183cf35 into gitpython-developers:main Oct 14, 2022
@Byron Byron added this to the v3.1.30 - Bugfixes milestone Oct 14, 2022
@Byron
Copy link
Member

Byron commented Oct 14, 2022

Thanks a lot, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants