Proposed change to get_values behavior #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposed fix for #1534 |
|
Looking at test here; I suppose we can leave it raising a KeyError. The main fix was force-loading the I'll re-commit using KeyError. |
kfreezen
force-pushed
the
fix/get_values
branch
from
c18b319
to
cfc613a
Compare
Byron
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Thanks a lot, much appreciated!
I think the commit should link back to the issue it resolve to create a more declarative history.
Finally it should be possible to devise a test that would fail without this change to cement it. Otherwise it might be removed in future because it's unclear why eager loading of sections is necessary.
|
@kfreezen, consider accepting kfreezen#1 to add test coverage for this change? I verified it fails on main:
|
|
Closing as it's superseded by #1555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_values() did not load existing sections before checking the
_sectionsproperty.NOTE: Haven't written a test to check for this yet.