Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure tox #1667

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Configure tox #1667

merged 4 commits into from
Sep 19, 2023

Commits on Sep 18, 2023

  1. Start setting up tox

    It is not completely working yet.
    EliahKagan committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    cd052b2 View commit details
    Browse the repository at this point in the history
  2. Pass through SSH_ env vars to tox envs

    This fixes a problem where the tests for fetching a nonexistent ref
    prompt like "Enter passphrase for key '/home/USERNAME/.ssh/id_rsa':"
    and block, if the repository on the machine where the tests are
    being run has the remote set up using an SSH URL.
    
    This passes through all environment variables whose names start
    with SSH_, even though it should be enough to pass SSH_AGENT_PID
    and SSH_AUTH_SOCK through, at least for this particular issue.
    EliahKagan committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2cc2db7 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Don't have mypy failure fail the whole tox run

    Other environments would still be run even after mypy has failed,
    but to avoid having tox runs be unnecessarily inconsistent with the
    mypy step in the pythonpackage.yml CI workflow, and also because
    GitPython is not currently expected to pass mypy checks, this keeps
    mypy errors from causing the whole tox run to be reported as
    failed.
    EliahKagan committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4bea7cf View commit details
    Browse the repository at this point in the history
  2. Add tox environment to build HTML documentation

    The main use of this, similar to the step at the end of
    pythonpackage.yml, is to find errors produced by building.
    
    However, actual documentation *is* built, and unlike other tox
    environments, running this one actually writes outside the .tox/
    directory, creating the documentation in the usual target
    location. For that reason, this environment is omitted from the
    env_list, so that it does not run by default and unexpectedly
    overwrite documentation that may recently have been built before
    changes are made that could cause generated documentation to be
    different.
    EliahKagan committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e6ec6c8 View commit details
    Browse the repository at this point in the history