Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have init script clone submodules unconditionally #1715

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Have init script clone submodules unconditionally #1715

merged 2 commits into from
Oct 18, 2023

Commits on Oct 18, 2023

  1. Don't pre-clone submodules on CI, at least for now 

    This has actions/checkout no longer automatically clone submodules
in the CI test workflows. This change is for the purpose of
reproducing gitpython-developers#1713, to allow the forthcoming fix for it to be
tested.

However, continuing to rely on init-tests-after-clone.sh to get the
submodules would serve as a kind of regression testing for gitpython-developers#1713.
So it is unclear at this time if and when this change should be
undone.
    @EliahKagan
    EliahKagan committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    bb48c87 View commit details
    Browse the repository at this point in the history

  2. Have init script clone submodules unconditionally 

    Since 7110bf8 (in gitpython-developers#1693), "git submodule update --init --recursive"
was not run on CI, on the mistaken grounds that the CI test
workflows would already have taken care of cloning all submodules
(ever since 4eef3ec when the "submodules: recursive" option was
added to the actions/checkout step).

This changes the init-tests-after-clone.sh script to again run that
command unconditionally, including on CI. The assumption that it
wasn't needed on CI was based on the specific content of
GitPython's own GitHub Actions workflows. But this disregarded that
the test suite is run on CI for *other* projects: specifically, for
downstream projects that package GitPython (gitpython-developers#1713).

This also brings back the comment from fc96980 that says more about
how the tests rely on submodules being present (specifically, that
they need a submodule with a submodule). However, that is not
specifically related to the bug being fixed.
    @EliahKagan
    EliahKagan committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8ea3133 View commit details
    Browse the repository at this point in the history