fix(loose): avoid unnecessary file rename on windows

This should workaround possible permission issues. Related to gitpython-developers/GitPython#353
gitpython-developers · Oct 4, 2015 · 2389b75 · 2389b75
1 parent 1741302
commit 2389b75
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/gitdb/db/loose.py b/gitdb/db/loose.py
@@ -226,10 +226,15 @@ def store(self, istream):
                 mkdir(obj_dir)
             # END handle destination directory
             # rename onto existing doesn't work on windows
-            if os.name == 'nt' and isfile(obj_path):
-                remove(obj_path)
-            # END handle win322
-            rename(tmp_path, obj_path)
+            if os.name == 'nt':
+                if isfile(obj_path):
+                    remove(tmp_path)
+                else:
+                    rename(tmp_path, obj_path)
+                # end rename only if needed
+            else:
+                rename(tmp_path, obj_path)
+            # END handle win32
 
             # make sure its readable for all ! It started out as rw-- tmp file
             # but needs to be rwrr

diff --git a/gitdb/ext/smmap b/gitdb/ext/smmap