refact(minor): use region.priv-func, close fd on same condition

gitpython-developers · Oct 25, 2016 · bba086a · bba086a
1 parent 7c1eac7
commit bba086a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/smmap/mman.py b/smmap/mman.py
@@ -319,9 +319,11 @@ def _collect_lru_region(self, size):
             lru_list = None
             for regions in self._fdict.values():
                 for region in regions:
-                    # check client count - if it's 1, it's just us
+                    ## Check client count - if it's 1, it's just us.
+                    #
                     if (region.client_count() == 1 and
-                            (lru_region is None or region._uc < lru_region._uc)):
+                            (lru_region is None or
+                             region.client_count() < lru_region.client_count())):
                         lru_region = region
                         lru_list = regions
                     # END update lru_region

diff --git a/smmap/util.py b/smmap/util.py
@@ -166,7 +166,7 @@ def __init__(self, path_or_fd, ofs, size, flags=0):
                 self._mfb = buffer(self._mf, ofs, self._size)
             # END handle buffer wrapping
         finally:
-            if isinstance(path_or_fd, string_types()):
+            if not isinstance(path_or_fd, int):
                 os.close(fd)
             # END only close it if we opened it
         # END close file handle